Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1763/metrics feature/new triggers for broken page pings #430

Closed
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
4ecd3d0
Update broken ping reload threshhold to 60 seconds
wlycdgr Jul 17, 2019
9c74083
Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-…
wlycdgr Jul 19, 2019
1ed578e
Add startPossibleBrokenPageTimer method to Metrics, implement the del…
wlycdgr Jul 22, 2019
99305fc
Implement metrics broken page trigger handler that uses existing even…
wlycdgr Jul 22, 2019
52e9a7a
Add setup_pth and setup_block parameters to broken_page ping
wlycdgr Jul 22, 2019
311b498
Clear and reset broken page watcher setTimeout handler if a new trigg…
wlycdgr Jul 22, 2019
dd1d215
Add pause Ghostery trigger for Metrics broken page watcher
wlycdgr Jul 22, 2019
49281a8
Add local tracker unblock trigger for Metrics broken page watcher.
wlycdgr Jul 22, 2019
5e5d996
Handle new tab creation for broken page watcher. Add documentation co…
wlycdgr Jul 23, 2019
f2c49ab
Remove broken page metrics ping call from TabInfo#create
wlycdgr Jul 23, 2019
0664aa5
Revert smart unblock threshold to 30 seconds. Add comments explaining…
wlycdgr Jul 23, 2019
28da0df
Trigger metrics broken page watcher on individual tracker site specif…
wlycdgr Jul 23, 2019
e7cd1bc
Pacify linter
wlycdgr Jul 23, 2019
e0076c1
Only set broken page watcher on whitelist add, not both add and remove
wlycdgr Jul 23, 2019
b9cf1ee
Change this.BROKEN_APGE_NEW_TAB value to a less mysterious 5. RIP Age…
wlycdgr Jul 23, 2019
0f5a592
Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-…
wlycdgr Jul 29, 2019
d286689
Correct timeout handler name in Metrics#_resetBrokenPageWatcher
wlycdgr Jul 29, 2019
aa76f53
Correct broken_page ping name in Metrics#handleBrokenPageTrigger
wlycdgr Jul 29, 2019
4e18aaa
Bind setTimeout handler to Metrics instance in getActiveTab callback …
wlycdgr Jul 29, 2019
6634a9b
Merge branch 'develop' into GH-1763/metrics-feature/new-triggers-for-…
christophertino Jul 29, 2019
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Trigger metrics broken page watcher on individual tracker site specif…
…ic or global unblock as well as on site-specific allow
  • Loading branch information
wlycdgr committed Jul 23, 2019
commit 28da0dffd1b83f4592a35dd415755e0021b8fc6c
@@ -144,6 +144,7 @@ const _updateTrackerTrustRestrict = (state, action) => {
sendMessage('setPanelData', {
site_specific_unblocks: updated_site_specific_unblocks,
site_specific_blocks: updated_site_specific_blocks,
brokenPageMetricsTrackerTrustOrUnblock: msg.trust || (!msg.trust && !msg.restrict),
});

return {
@@ -214,7 +214,10 @@ export function updateTrackerBlocked(state, action) {
});

// persist to background
sendMessage('setPanelData', { selected_app_ids: updated_app_ids });
sendMessage('setPanelData', {
selected_app_ids: updated_app_ids,
brokenPageMetricsTrackerTrustOrUnblock: !blocked
});

return {
categories: updated_categories,
@@ -1096,10 +1096,6 @@ function initializeDispatcher() {
// can't simply compare num_selected and size(db.apps) since apps get removed sometimes
db.allSelected = (!!num_selected && every(db.apps, (app, app_id) => appIds.hasOwnProperty(app_id)));
});
dispatcher.on('conf.save.site_specific_unblocks', () => {
// if user has unblock a tracker on this page, suspect a broken page
metrics.handleBrokenPageTrigger(globals.BROKEN_PAGE_LOCAL_TRACKER_UNBLOCK);
})
dispatcher.on('conf.save.site_whitelist', () => {
// TODO debounce with below
button.update();
@@ -74,7 +74,7 @@ class Globals {
this.BROKEN_PAGE_REFRESH = 1;
this.BROKEN_PAGE_WHITELIST = 2;
this.BROKEN_PAGE_PAUSE = 3;
this.BROKEN_PAGE_LOCAL_TRACKER_UNBLOCK = 4;
this.BROKEN_PAGE_TRACKER_TRUST_OR_UNBLOCK = 4;
this.BROKEN_PAGE_NEW_TAB = 86;

// data stores
@@ -21,6 +21,7 @@ import conf from './Conf';
import foundBugs from './FoundBugs';
import bugDb from './BugDb';
import globals from './Globals';
import metrics from './Metrics';
import Policy from './Policy';
import tabInfo from './TabInfo';
import rewards from './Rewards';
@@ -643,6 +644,10 @@ class PanelData {
tabInfo.setTabInfo(this._activeTab.id, 'needsReload', data.needsReload);
}

if (data.brokenPageMetricsTrackerTrustOrUnblock) {
metrics.handleBrokenPageTrigger(globals.BROKEN_PAGE_TRACKER_TRUST_OR_UNBLOCK);
}

if (syncSetDataChanged) {
// Push conf changes to the server
account.saveUserSettings().catch(err => log('PanelData saveUserSettings', err));
ProTip! Use n and p to navigate between commits in a pull request.