GH-1799: Fix Sitewide Trust/Restrict & Update UI for Consistency #431
Conversation
… site is restrited
Eden12345
requested review from
IAmThePan,
jsignanini,
zarembsky and
ghostery/ghostery
as
code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
JIRA Ticket: https://cliqztix.atlassian.net/browse/GH-1799
Note
I noticed when working on this ticket that the Unknown category was a bit confusing when you select "Restrict Site", since it looks different than all of the other categories. I updated the Unknown category trackers so that their whitelisting features were inaccessible in this state (to match the other categories) and coordinated with @vincentlai88 to ensure that the design was as aligned as possible.