Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1799: Fix Sitewide Trust/Restrict & Update UI for Consistency #431

Merged
merged 2 commits into from Jul 30, 2019
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Fix URL processing in Policy class and update UI for consistency when…
… site is restrited
  • Loading branch information
Eden12345 committed Jul 30, 2019
commit 0ad5fbdb07705e11fbe02d4d23e66bb43808f652
@@ -34,6 +34,7 @@ class Categories extends React.Component {
expandAll,
antiTracking,
enable_anti_tracking,
sitePolicy,
} = this.props;
const globalBlocking = !!this.props.globalBlocking;
const filtered = !!this.props.filtered;
@@ -55,6 +56,7 @@ class Categories extends React.Component {
name: unknownTracker.name,
domains: unknownTracker.domains,
whitelisted: unknownTracker.whitelisted,
siteRestricted: sitePolicy === 1,
blocked: false,
catId: 'anti_tracking_unknown',
description: '',
@@ -230,7 +230,7 @@ class Category extends React.Component {
</span>
</div>
{((!isUnknown && !!trackersBlockedCount)
|| (isUnknown && !!category.whitelistedTotal)) && (
|| (isUnknown && !!category.whitelistedTotal && sitePolicy !== 1)) && (
<div className={`blocked-count${isUnknown ? ' ghosty-blue' : ''}`}>
<span className="count">
{isUnknown ? `${category.whitelistedTotal} ` : `${trackersBlockedCount} `}
@@ -316,7 +316,7 @@ class Tracker extends React.Component {
}

const trackerNameClasses = ClassNames('trk-name', {
'is-whitelisted': tracker.whitelisted,
'is-whitelisted': tracker.whitelisted && !tracker.siteRestricted,
});

return (
@@ -344,6 +344,7 @@ class Tracker extends React.Component {
) : renderUnknownTrackerButtons(
this.handleAntiTrackingWhitelist,
tracker.whitelisted,
tracker.siteRestricted,
)}
</div>
</div>
@@ -53,8 +53,13 @@ export const renderKnownTrackerButtons = (
</div>
);

export const renderUnknownTrackerButtons = (handleAntiTrackingWhitelist, whitelisted) => {
const svgContainerClasses = ClassNames('unknown-svg-container', { whitelisted });
export const renderUnknownTrackerButtons = (
handleAntiTrackingWhitelist, whitelisted, siteRestricted
) => {
const svgContainerClasses = ClassNames('unknown-svg-container', {
whitelisted: whitelisted && !siteRestricted,
siteRestricted,
});

return (
<div className={svgContainerClasses}>
@@ -184,6 +184,10 @@
visibility: visible;
}
}

&.siteRestricted {
pointer-events: none;
}
}
}

@@ -1279,11 +1279,8 @@ function initialiseWebRequestPipeline() {
* @return {boolean}
*/
function isWhitelisted(state) {
const hostUrl = utils.processUrl(state.tabUrl).host;
const trackerUrl = utils.processUrl(state.url).host;

// state.ghosteryWhitelisted is sometimes undefined so force to bool
return Boolean(globals.SESSION.paused_blocking || events.policy.getSitePolicy(hostUrl, trackerUrl) === 2 || state.ghosteryWhitelisted);
return Boolean(globals.SESSION.paused_blocking || events.policy.getSitePolicy(state.tabUrl, state.url) === 2 || state.ghosteryWhitelisted);
}

/**
@@ -18,6 +18,7 @@
import c2pDb from './Click2PlayDb';
import conf from './Conf';
import globals from './Globals';
import { processUrl } from '../utils/utils';

/**
* Enum for reasons returned by shouldBlock
@@ -62,8 +63,9 @@ class Policy {
* @return {string|boolean} corresponding whitelist entry or false, if none
*/
checkSiteWhitelist(url) {
if (url) {
const replacedUrl = url.replace(/^www\./, '');
const hostUrl = processUrl(url).host;
if (hostUrl) {
const replacedUrl = hostUrl.replace(/^www\./, '');
const sites = conf.site_whitelist || [];
const num_sites = sites.length;

@@ -86,11 +88,13 @@ class Policy {
*/
checkAntiTrackingWhitelist(hostUrl, trackerUrl) {
let isWhitelisted = false;
const processedHostUrl = processUrl(hostUrl).host;
const processedTrackerUrl = processUrl(trackerUrl).host;
const antiTrackingWhitelist = conf.anti_tracking_whitelist;

if (antiTrackingWhitelist[trackerUrl]) {
antiTrackingWhitelist[trackerUrl].hosts.some((host) => {
if (host === hostUrl) {
if (antiTrackingWhitelist[processedTrackerUrl]) {
antiTrackingWhitelist[processedTrackerUrl].hosts.some((host) => {
if (host === processedHostUrl) {
isWhitelisted = true;
return true;
}
@@ -107,8 +111,9 @@ class Policy {
* @return {string|boolean} corresponding blacklist entry or false, if none
*/
blacklisted(url) {
if (url) {
const replacedUrl = url.replace(/^www\./, '');
const hostUrl = processUrl(url).host;
if (hostUrl) {
const replacedUrl = hostUrl.replace(/^www\./, '');
const sites = conf.site_blacklist || [];
const num_sites = sites.length;

ProTip! Use n and p to navigate between commits in a pull request.