Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 1767/bugfix/target blank links crash opera #432

Merged
merged 23 commits into from Jul 30, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Jul 30, 2019

Fix Opera broken link bug for "Learn more" link in pitch modal in Historical Stats view.

Double-checked to see if there are any other places I missed the first time around. I believe I got them all.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr and others added 23 commits Jul 23, 2019
…rk on Opera as well as in other browsers
…tion component. Use this component in About view to fix the broken-in-Opera links there
…account view in the panel so that the links work on Opera
…ent to reduce duplication
…pera
…d openFixedDestinationLinkInNewTab. Fix bug in I18nWithLink#componentDidMount.
…b.com:ghostery/ghostery-extension into GH-1767/bugfix/target-blank-links-crash-Opera
@wlycdgr wlycdgr requested review from IAmThePan and ghostery/ghostery as code owners Jul 30, 2019
@wlycdgr wlycdgr requested a review from christophertino Jul 30, 2019
@christophertino christophertino added this to the 8.4.1 milestone Jul 30, 2019
@christophertino christophertino merged commit ff04783 into develop Jul 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1767/bugfix/target-blank-links-crash-Opera branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants