Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1798: Update Unknown category to include Ad Blocker unknowns #433

Merged
merged 10 commits into from Aug 2, 2019
Merged

GH-1798: Update Unknown category to include Ad Blocker unknowns #433

merged 10 commits into from Aug 2, 2019

Conversation

@Eden12345
Copy link
Contributor

@Eden12345 Eden12345 commented Jul 31, 2019 •
edited by christophertino

JIRA Ticket: https://cliqztix.atlassian.net/browse/GH-1798

This PR is on hold pending implementation of pattern-specific whitelisting functionality in the Ad Blocker.

cc @remusao
Eden12345 added 2 commits Jul 31, 2019
@Eden12345
Use total trackers displayed for tracker count, rather than all modif…
Loading status checks…
2a0a3ea 
…ied requests
@Eden12345
Add unknownTrackerCount to adBlock in reducer in case it's needed later
Loading status checks…
8a2289b
@Eden12345 Eden12345 requested review from christophertino and wlycdgr Jul 31, 2019
@Eden12345 Eden12345 requested a review from ghostery/ghostery as a code owner Jul 31, 2019
@Eden12345
Only count requests modified by tracker, update browser button
Loading status checks…
daff71e
@christophertino christophertino added this to the 8.4.1 milestone Jul 31, 2019
Eden12345 added 2 commits Jul 31, 2019
@Eden12345
Update tests, use better variable names, update duplicate cases in re…
Loading status checks…
f33b017 
…ducers
@Eden12345
Combine Ad Blocking unknown trackers with Anti-Tracking into one Unkn…
Loading status checks…
b5d7668 
…own category in the tracker list
@Eden12345 Eden12345 requested a review from zarembsky as a code owner Aug 1, 2019
Eden12345 and others added 3 commits Aug 2, 2019
@Eden12345
Fix UI whitelist update bug and update variable names
Loading status checks…
6a152b0
@Eden12345
Fix variable names and remove linter warnings
Loading status checks…
7925769
@christophertino
update DonutGraph to handle adBlock unknown counts
Loading status checks…
0c1d9ad
@christophertino christophertino changed the title GH-1801: Fix Total Tracker Count GH-1798: Update Unknown category to include Ad Blocker unknowns Aug 2, 2019
@christophertino christophertino modified the milestones: 8.4.1, 8.4.2 Aug 2, 2019
@christophertino christophertino removed request for zarembsky and wlycdgr Aug 2, 2019
@christophertino
remove unused SVG
Loading status checks…
ae41fce
@christophertino
temporarily remove whitelist buttons from ad-block unknowns
Loading status checks…
8406660
@christophertino
christophertino approved these changes Aug 2, 2019
View changes
@christophertino christophertino modified the milestones: 8.4.2, 8.4.1 Aug 2, 2019
@christophertino christophertino merged commit f6db314 into develop Aug 2, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the fix/totalTrackerCount branch Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Eden12345 @christophertino