Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1832/change intro hub copy to be opt in #436

Merged
merged 5 commits into from Aug 22, 2019
+9 −3
Merged

GH-1832/change intro hub copy to be opt in #436

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
861034b
Update Intro Hub copy to be opt-in for Rewards and HW
wlycdgr Aug 20, 2019
a97445c
Only show opt in copy if user is using Firefox
wlycdgr Aug 20, 2019
8ddb240
Update home header info opted out string key. Simplify headerInfoText…
wlycdgr Aug 20, 2019
720ea2d
Pacify linter re: tabs vs spaces. Remove extra space in messages
wlycdgr Aug 20, 2019
906191c
Merge branch 'develop' into GH-1832/change-intro-hub-copy-to-be-opt-in
christophertino Aug 22, 2019
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Pacify linter re: tabs vs spaces. Remove extra space in messages

  • Loading branch information
@wlycdgr
wlycdgr committed Aug 20, 2019
commit 720ea2db5800e1b3f286c45aef357b078b5a7ec7
2 _locales/en/messages.json
View file
Open in desktop
@@ -1369,7 +1369,7 @@
"message": "Sign In"
},
"hub_side_navigation_log_out": {
"message": "Sign Out"
"message": "Sign Out"
},
"hub_home_page_title": {
"message": "Ghostery Hub - Home"
6 app/hub/Views/HomeView/HomeView.jsx
View file
Open in desktop
@@ -34,9 +34,9 @@ const HomeView = (props) => {
isPlus,
} = props;
const accountHref = `https://account.${globals.GHOSTERY_DOMAIN}.com`;
const headerInfoText = (globals.BROWSER_INFO && globals.BROWSER_INFO.name === 'firefox')
? t('hub_home_header_info_opted_out')
: t('hub_home_header_info');
const headerInfoText = (globals.BROWSER_INFO && globals.BROWSER_INFO.name === 'firefox')
? t('hub_home_header_info_opted_out')
: t('hub_home_header_info');
const tutorialFeatureClassNames = ClassNames('HomeView__onboardingFeature columns flex-container align-middle flex-dir-column', {
'feature-tutorial-complete': tutorial_complete,
'feature-tutorial': !tutorial_complete,
ProTip! Use n and p to navigate between commits in a pull request.