Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1832/change intro hub copy to be opt in #436

Merged
merged 5 commits into from Aug 22, 2019
+9 −3
Merged

GH-1832/change intro hub copy to be opt in #436

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
861034b
Update Intro Hub copy to be opt-in for Rewards and HW
wlycdgr Aug 20, 2019
a97445c
Only show opt in copy if user is using Firefox
wlycdgr Aug 20, 2019
8ddb240
Update home header info opted out string key. Simplify headerInfoText…
wlycdgr Aug 20, 2019
720ea2d
Pacify linter re: tabs vs spaces. Remove extra space in messages
wlycdgr Aug 20, 2019
906191c
Merge branch 'develop' into GH-1832/change-intro-hub-copy-to-be-opt-in
christophertino Aug 22, 2019
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…

Update Intro Hub copy to be opt-in for Rewards and HW

  • Loading branch information
@wlycdgr
wlycdgr committed Aug 20, 2019
commit 861034bdf42cb7d28ea48c967457d712df5dcd8b
4 _locales/en/messages.json
View file
Open in desktop
@@ -1369,7 +1369,7 @@
"message": "Sign In"
},
"hub_side_navigation_log_out": {
"message": "Sign Out"
"message": "Sign Out"
This conversation was marked as resolved by wlycdgr

This comment has been minimized.

Sign in to view
@Eden12345

Eden12345 Aug 20, 2019
Contributor

I think you typed a space here by accident 😶

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Aug 20, 2019
Author Member

Whaaa! How, Zarembsky!

This comment has been minimized.

Sign in to view
@wlycdgr

wlycdgr Aug 20, 2019
Author Member

Fixed
},
"hub_home_page_title": {
"message": "Ghostery Hub - Home"
@@ -1387,7 +1387,7 @@
"message": "Share additional anonymous analytics data to improve Ghostery’s performance."
},
"hub_home_header_info": {
"message": "New users are opted in to participating in Human Web and Ghostery Rewards. You may change these settings in custom setup or in the extension. "
"message": "New users are opted out of participating in Ghostery Rewards and Human Web by default. You may opt in to these recommended features in custom setup or in the extension. "
},
"hub_home_header_info_link": {
"message": "Learn More."
ProTip! Use n and p to navigate between commits in a pull request.