Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1832/change intro hub copy to be opt in #436
GH-1832/change intro hub copy to be opt in #436
Changes from 1 commit
861034ba97445c8ddb240720ea2d906191cFile filter
Jump to
Only show opt in copy if user is using Firefox
Eden12345Aug 20, 2019
Contributor
I know this is nitpicky, but can we call this
hub_home_header_info_opted_outinstead? Just because the key difference between this and thehub_home_header_infostring is that the former says "New users are opted out of particpating..." in the first sentence.wlycdgrAug 20, 2019
Author
Member
done
Eden12345Aug 20, 2019
•
edited
Contributor
Can we shorten this line to:
(globals.BROWSER_INFO && globals.BROWSER_INFO.name === 'firefox')since
BROWSER_INFO.namewon't equal'firefox'if it'sundefinedornull, anyway?wlycdgrAug 20, 2019
Author
Member
done