Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-core: update to v7.39 #439

Closed
wants to merge 1 commit into from

Conversation

@remusao
Copy link
Contributor

@remusao remusao commented Aug 22, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Because it has been a while since the last update, I have been through the list of commits to check for potential breaking changes and found none (hopefully I have not missed anything). On the other hand, here are a few improvements compared to previous version:

  • much faster URL parsing with @cliqz/url-parser + new version of tldts (used to extract public suffixes), expected at least 30% speed-up
  • updated adblocker with following improvements:
    • more efficient cosmetic filtering
    • removes size limit and lower memory usage while updates/initializations
    • drastic reduction in content-script bundle size by removing un-needed symbols
  • refreshed content-scriptr/background communication to simplify and improve efficiency. The most noticeable effect should be a reduced latency when content-script communicates with background modules thanks to better use of callbacks in sendMessage(...) invocations.

I also tried the updated Ghostery locally and blocking (anti-tracking, adblocking, etc.) seem to work as expected.

@remusao remusao requested a review from ghostery/ghostery as a code owner Aug 22, 2019
@christophertino christophertino added this to the 8.4.3 milestone Aug 22, 2019
@remusao remusao force-pushed the remusao:upgrade-browser-core branch from 758c0ed to ce5ac06 Aug 27, 2019
@christophertino
Copy link
Member

@christophertino christophertino commented Aug 29, 2019

Closing in favor of #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants