Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tools for AMO submissions #441

Merged
merged 7 commits into from Aug 26, 2019

add nvm install version for ghostery

  • Loading branch information
christophertino committed Aug 26, 2019
commit 09289f9409725b5a24756b11ef37b94777e38220
@@ -139,7 +139,7 @@ Cliqz modules are pre-built and included under the `browser-core` NPM dependency

```sh
$ npm ci
$ ./fern.js build configs/ghostery.js --no-maps --no-debug --environment=production
$ ./fern.js build configs/ghostery.js --environment=production --no-debug
```

## Compatibility
@@ -41,7 +41,7 @@ rm -rf node_modules
npm ci

# Build a production version of browser-core for Ghostery
./fern.js build configs/ghostery.js --no-maps --no-debug --environment=production
./fern.js build configs/ghostery.js --environment=production --no-debug

echo "Browser Core build complete. Please see build/ directory."

@@ -81,6 +81,7 @@ rm -rf build
rm -rf node_modules

# Set node version
nvm install lts/carbon
nvm use
This conversation was marked as resolved by christophertino

This comment has been minimized.

@luciancor

luciancor Aug 26, 2019
Contributor

this line throws Found '.../ghostery-extension/tools/amo/ghostery-source/ghostery-extension-8.4.1/.nvmrc' with version <lts/carbon>
any idea why? can it be due to me changing to version 8.4.1 to use something released ?

This comment has been minimized.

@sammacbeth

sammacbeth Aug 26, 2019
Contributor

I think you have to run nvm install <version> before nvm use can select it.

This comment has been minimized.

@christophertino

christophertino Aug 26, 2019
Author Member

I'll add that to the README Added to the build routine for ghostery


# Install local npm packages
ProTip! Use n and p to navigate between commits in a pull request.