Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1607: Remove Ghostery rewards toggle, and add language for Cliqz Browser #450
GH-1607: Remove Ghostery rewards toggle, and add language for Cliqz Browser #450
Changes from 1 commit
363cb0acaba482File filter
Jump to
Remove ghostery rewards toggle and add language for Cliqz Browser
jsignaniniSep 17, 2019
Member
It looks like we're only using
ghostery_rewards_enabledright here, would it be clearer to replace this with!IS_CLIQZinstead?benstrumeyerSep 17, 2019
Author
Contributor
Definitely agree. I've removed the variable entirely and replaced it with !IS_CLIQZ.
jsignaniniSep 17, 2019
Member
We add the
.defaultPropsat the bottom of the file, separate from the class or function declaration. See other.defaultPropsdeclarations as guidance.benstrumeyerSep 17, 2019
Author
Contributor
Very neat. I have moved it to the bottom of the file.