Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1814/Promo-toggle #451

Closed
wants to merge 2 commits into from
Closed

GH-1814/Promo-toggle #451

wants to merge 2 commits into from
+13 −1

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 18, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Implement a an opt-out checkbox that allows users to turn in-app promos on/off.
@benstrumeyer
Add language and toggle for notify_promotions
Loading status checks…
14563ff
@benstrumeyer
Change label name
Loading status checks…
e9e1a7e
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 18, 2019
@benstrumeyer benstrumeyer requested review from zarembsky and ghostery/ghostery as code owners Sep 18, 2019
@benstrumeyer benstrumeyer self-assigned this Sep 18, 2019
@benstrumeyer benstrumeyer removed request for ghostery/ghostery and zarembsky Sep 18, 2019
@christophertino christophertino added this to the 8.4.5 milestone Sep 19, 2019
@wlycdgr wlycdgr closed this Sep 20, 2019
@wlycdgr wlycdgr deleted the feature/promo-toggle branch Oct 18, 2019
@christophertino christophertino removed this from the 8.4.5 milestone Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr