Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1814/promo toggle #453

Merged
merged 2 commits into from Oct 18, 2019
Merged

GH-1814/promo toggle #453

merged 2 commits into from Oct 18, 2019

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 20, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Implement a an opt-out checkbox that allows users to turn in-app promos on/off.
@benstrumeyer
Add language and toggle for notify_promotions
Loading status checks…
14563ff
@benstrumeyer
Change label name
Loading status checks…
e9e1a7e
@benstrumeyer benstrumeyer added this to the 8.4.5 milestone Sep 20, 2019
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 20, 2019
@benstrumeyer benstrumeyer requested review from zarembsky and ghostery/ghostery as code owners Sep 20, 2019
@benstrumeyer benstrumeyer self-assigned this Sep 20, 2019
@benstrumeyer benstrumeyer removed request for ghostery/ghostery and zarembsky Sep 20, 2019
@benstrumeyer benstrumeyer changed the title Feature/promo toggle GH-1814/promo toggle Sep 23, 2019
@wlycdgr
wlycdgr approved these changes Sep 23, 2019
View changes
Copy link
Member

@wlycdgr wlycdgr left a comment •
edited

Looks good.
@christophertino
Copy link
Member

@christophertino christophertino commented Sep 25, 2019

Looks good, we'll park this until 8.4.5
@wlycdgr wlycdgr merged commit e47a0c3 into release/8.4.5 Oct 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@wlycdgr wlycdgr deleted the feature/promo-toggle branch Oct 18, 2019
benstrumeyer added a commit that referenced this pull request Oct 18, 2019
@benstrumeyer
GH-1814/promo toggle (#453)
4b7b84a 
* Add language and toggle for notify_promotions

* Change label name
wlycdgr added a commit that referenced this pull request Oct 24, 2019
@benstrumeyer @wlycdgr
GH-1774/In-App Insights Promo (#460)
Loading status checks…
6e6c8d3 
* Created modal UI

* Change feature language. Add exit button.

* Add insights modal that will appear if a user clicks 3x per day for 3 days. Users subscribed to insights will not be shown promos.

* Refactor insights modal into a component. Reshow modal after prompted to log in on summary page.

* Clean up insights modal code

* Show plus promo modal on first view of Home view of each Hub session

* Stub out intro hub plus promo modal layout and implement its buttons

* Remove some unnecessary plus promo modal related CSS

* Continue adding styling for plus promo modal

* Continue styling plus promo modal

* Refactor plus promo modal CSS to improve alignment of elements

* Continue CSS work for plus promo modal

* Implement recommended gold banner in plus promo modal

* Update and tweak plus promo modal design

* Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.

* Additional consolidation of redundant and unused entries in messages

* Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.

* Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic

* Create ModalPromos background class responsible for modal promo related business logic and state management

* Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background

* Make PromoModals code more robust

* Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal

* Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code

* Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.

* Clean up. Finish string localization in PlusPromoModal

* Plug in insights modal into promo modal class

* GH-1777 and GH-1776 Plus Promo modals (#458)

* Show plus promo modal on first view of Home view of each Hub session

* Stub out intro hub plus promo modal layout and implement its buttons

* Remove some unnecessary plus promo modal related CSS

* Continue adding styling for plus promo modal

* Continue styling plus promo modal

* Refactor plus promo modal CSS to improve alignment of elements

* Continue CSS work for plus promo modal

* Implement recommended gold banner in plus promo modal

* Update and tweak plus promo modal design

* Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.

* Additional consolidation of redundant and unused entries in messages

* Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.

* Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic

* Create ModalPromos background class responsible for modal promo related business logic and state management

* Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background

* Make PromoModals code more robust

* Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal

* Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code

* Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.

* Clean up. Finish string localization in PlusPromoModal

* Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify

* Remove debug console statement

* Consolidate insights promo with plus promo

* GH-1814/promo toggle (#453)

* Add language and toggle for notify_promotions

* Change label name

* User can opt out of promotions

* Remove empty SCSS class

* Add newlines

* Add hover effects

* Refactor insights promo to use redux. Remove summary component code. Remove redundant scss rules.

* Refactor hasEngagedFrequently to update in recordEngaged

* Refactor recordEngaged

* Fix recordEngaged bug

* Fix font paths

* Remove unused font asset
christophertino added a commit that referenced this pull request Oct 28, 2019
@benstrumeyer @christophertino
GH-1814/promo toggle (#453)
a4a433e 
* Add language and toggle for notify_promotions

* Change label name
christophertino added a commit that referenced this pull request Oct 28, 2019
@benstrumeyer @christophertino
GH-1774/In-App Insights Promo (#460)
7d08240 
* Created modal UI

* Change feature language. Add exit button.

* Add insights modal that will appear if a user clicks 3x per day for 3 days. Users subscribed to insights will not be shown promos.

* Refactor insights modal into a component. Reshow modal after prompted to log in on summary page.

* Clean up insights modal code

* Show plus promo modal on first view of Home view of each Hub session

* Stub out intro hub plus promo modal layout and implement its buttons

* Remove some unnecessary plus promo modal related CSS

* Continue adding styling for plus promo modal

* Continue styling plus promo modal

* Refactor plus promo modal CSS to improve alignment of elements

* Continue CSS work for plus promo modal

* Implement recommended gold banner in plus promo modal

* Update and tweak plus promo modal design

* Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.

* Additional consolidation of redundant and unused entries in messages

* Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.

* Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic

* Create ModalPromos background class responsible for modal promo related business logic and state management

* Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background

* Make PromoModals code more robust

* Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal

* Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code

* Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.

* Clean up. Finish string localization in PlusPromoModal

* Plug in insights modal into promo modal class

* GH-1777 and GH-1776 Plus Promo modals (#458)

* Show plus promo modal on first view of Home view of each Hub session

* Stub out intro hub plus promo modal layout and implement its buttons

* Remove some unnecessary plus promo modal related CSS

* Continue adding styling for plus promo modal

* Continue styling plus promo modal

* Refactor plus promo modal CSS to improve alignment of elements

* Continue CSS work for plus promo modal

* Implement recommended gold banner in plus promo modal

* Update and tweak plus promo modal design

* Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.

* Additional consolidation of redundant and unused entries in messages

* Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.

* Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic

* Create ModalPromos background class responsible for modal promo related business logic and state management

* Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background

* Make PromoModals code more robust

* Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal

* Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code

* Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.

* Clean up. Finish string localization in PlusPromoModal

* Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify

* Remove debug console statement

* Consolidate insights promo with plus promo

* GH-1814/promo toggle (#453)

* Add language and toggle for notify_promotions

* Change label name

* User can opt out of promotions

* Remove empty SCSS class

* Add newlines

* Add hover effects

* Refactor insights promo to use redux. Remove summary component code. Remove redundant scss rules.

* Refactor hasEngagedFrequently to update in recordEngaged

* Refactor recordEngaged

* Fix recordEngaged bug

* Fix font paths

* Remove unused font asset
@christophertino christophertino modified the milestones: 8.4.5, 8.4.4 Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
8.4.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benstrumeyer @christophertino @wlycdgr