Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to toggle smart blocking on Cliqz browser #455

Merged
merged 2 commits into from Sep 25, 2019
Merged

Add ability to toggle smart blocking on Cliqz browser #455

merged 2 commits into from Sep 25, 2019

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Sep 25, 2019

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

Add ability to toggle smart blocking on Cliqz browser.
@benstrumeyer
Add ability to toggle smart blocking on Cliqz browser
Loading status checks…
4b88e87
@benstrumeyer benstrumeyer added this to the 8.4.3 milestone Sep 25, 2019
@benstrumeyer benstrumeyer requested a review from wlycdgr Sep 25, 2019
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Sep 25, 2019
@benstrumeyer benstrumeyer self-assigned this Sep 25, 2019
@benstrumeyer benstrumeyer removed the request for review from ghostery/ghostery Sep 25, 2019
@benstrumeyer
Refactor code to separate smart blocking inactive behavior
Loading status checks…
7ae7a2d
@christophertino christophertino requested a review from ghostery/ghostery Sep 25, 2019
@christophertino
christophertino approved these changes Sep 25, 2019
View changes
@christophertino christophertino merged commit 3e09ee1 into develop Sep 25, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1607/fix-smart-blocking-toggle branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@wlycdgr wlycdgr

Assignees

@benstrumeyer benstrumeyer

Labels
None yet
Projects
None yet
Milestone
8.4.3
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@benstrumeyer @christophertino