Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1777 and GH-1776 Plus Promo modals #458

Merged
merged 26 commits into from Oct 16, 2019
Merged

GH-1777 and GH-1776 Plus Promo modals #458

merged 26 commits into from Oct 16, 2019
+1,001 −563

Commits on Sep 16, 2019

  1. Show plus promo modal on first view of Home view of each Hub session

    @wlycdgr
    wlycdgr committed Sep 16, 2019
    5102f35

  2. Stub out intro hub plus promo modal layout and implement its buttons

    @wlycdgr
    wlycdgr committed Sep 16, 2019
    e1c1f54

Commits on Sep 17, 2019

  1. Remove some unnecessary plus promo modal related CSS

    @wlycdgr
    wlycdgr committed Sep 17, 2019
    64869a5

  2. Continue adding styling for plus promo modal

    @wlycdgr
    wlycdgr committed Sep 17, 2019
    5289bb9

Commits on Sep 18, 2019

  1. Continue styling plus promo modal

    @wlycdgr
    wlycdgr committed Sep 18, 2019
    ce1fac9

Commits on Sep 20, 2019

  1. Refactor plus promo modal CSS to improve alignment of elements

    @wlycdgr
    wlycdgr committed Sep 20, 2019
    361debe

  2. Merge branch 'develop' into GH-1777/plus-intro-hub-promo

    @wlycdgr
    wlycdgr committed Sep 20, 2019
    3c96366

  3. Continue CSS work for plus promo modal

    @wlycdgr
    wlycdgr committed Sep 20, 2019
    a60d6b4

Commits on Sep 23, 2019

  1. Implement recommended gold banner in plus promo modal

    @wlycdgr
    wlycdgr committed Sep 23, 2019
    4f84229

Commits on Sep 26, 2019

  1. Merge branch 'develop' into GH-1777/plus-intro-hub-promo

    @wlycdgr
    wlycdgr committed Sep 26, 2019
    3794709

Commits on Sep 27, 2019

  1. Update and tweak plus promo modal design

    @wlycdgr
    wlycdgr committed Sep 27, 2019
    5cb13d5

Commits on Oct 1, 2019

  1. Fix path bug in i18n-checker tool. Consolidate redundant entries in m… 

    …essages. Add check icon to plus promo modal. Modify plus promo modal css.
    @wlycdgr
    wlycdgr committed Oct 1, 2019
    f6d3298

Commits on Oct 2, 2019

  1. Additional consolidation of redundant and unused entries in messages

    @wlycdgr
    wlycdgr committed Oct 2, 2019
    4b16723

Commits on Oct 3, 2019

  1. Merge branch 'develop' into GH-1777/plus-intro-hub-promo

    @wlycdgr
    wlycdgr committed Oct 3, 2019
    92d4923

  2. Merge branch 'develop' into GH-1777/plus-intro-hub-promo

    @wlycdgr
    wlycdgr committed Oct 3, 2019
    a1f102b

Commits on Oct 6, 2019

  1. Factor plus promo modal rendering out to shared component. Implement … 

    …rendering in panel. Implement display context CSS adjustments.
    @wlycdgr
    wlycdgr committed Oct 6, 2019
    569382e

Commits on Oct 7, 2019

  1. Move Plus Promo modal rendering to a PlusPromoModal shared component.… 

    … Begin to implement conditional panel display logic
    @wlycdgr
    wlycdgr committed Oct 7, 2019
    509f9eb

  2. Create ModalPromos background class responsible for modal promo relat… 

    …ed business logic and state management
    @wlycdgr
    wlycdgr committed Oct 7, 2019
    833fdff

Commits on Oct 8, 2019

  1. Add local state to Panel to make sure component rerenders after user … 

    …dismisses promo panel. Send record of promo interaction to background
    @wlycdgr
    wlycdgr committed Oct 8, 2019
    9e80640

  2. Make PromoModals code more robust

    @wlycdgr
    wlycdgr committed Oct 8, 2019
    b03e312

  3. Factor PlusPromoModal rendering out to helper in Panel. Extend condit… 

    …ional rendering logic to account for upgrade version of modal
    @wlycdgr
    wlycdgr committed Oct 8, 2019
    a1270cc

  4. Mark PromoModals methods as static. Refine PlusPromoModal implementat… 

    …ion and add debug code
    @wlycdgr
    wlycdgr committed Oct 8, 2019
    cac56c1

Commits on Oct 9, 2019

  1. Add logic to hide plus promo modal from Insights subscribers. Cleanup… 

    … and comments.
    @wlycdgr
    wlycdgr committed Oct 9, 2019
    be05ce9

  2. Clean up. Finish string localization in PlusPromoModal

    @wlycdgr
    wlycdgr committed Oct 9, 2019
    ee361ad

Commits on Oct 16, 2019

  1. Pull non-shared upgrade version of plus promo modal out of shared Plu… 

    …sPromoModal component and into Panel to simplify
    @wlycdgr
    wlycdgr committed Oct 16, 2019
    80d75fb

  2. Remove debug console statement

    @wlycdgr
    wlycdgr committed Oct 16, 2019
    7c85e94