Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for metrics bugs GH-1001 and GH-1022 #46

Closed
wants to merge 128 commits into from
Closed

Conversation

@zarembsky
Copy link
Contributor

@zarembsky zarembsky commented Apr 26, 2018

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
Serge Zarembsky and others added 30 commits Mar 8, 2018
Serge Zarembsky
Serge Zarembsky
Feature/gh 859
Serge Zarembsky
Serge Zarembsky
Serge Zarembsky
Fixes for UI bugs in Ghostery panel related to longer strings in German language (GH-869, GH-870, GH-872)
Serge Zarembsky
Serge Zarembsky
Refactoring load/unload of Cliqz modules, fix for GH-476.
Serge Zarembsky
Serge Zarembsky
Fixes for GH-877, GH-872, GH-886, missing translations added.
Serge Zarembsky
Serge Zarembsky
IAmThePan and others added 27 commits Apr 9, 2018
Fix scroll issue with tooltip
Automated extension builds
* GH-862 Add unit tests for the Panel: Pause Button Snapshot, Summary Actions & Reducers

* Update reducers to test for immutable state
Serge Zarembsky
Serge Zarembsky
@zarembsky zarembsky closed this Apr 26, 2018
@zarembsky
Copy link
Contributor Author

@zarembsky zarembsky commented Apr 26, 2018

Does not allow to change master to develop

@lidel

This comment has been minimized.

Copy link

@lidel lidel commented on src/classes/PolicySmartBlock.js in 5323f08 Jul 5, 2018

Worth including v6 version as well:

-		if (requestHost === 'localhost' || requestHost === '127.0.0.1') {
+		if (requestHost === 'localhost' || requestHost === '127.0.0.1' || requestHost === '[::1]') {

This comment has been minimized.

Copy link
Member Author

@christophertino christophertino replied Jul 6, 2018

Good catch, i'll add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants