New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for metrics bugs GH-1001 and GH-1022 #46
Closed
+11,784
−7,042
Load github credentials to enable moab checkout of ghostery-libraries.
07a7569
Select commit
262ca37
Fix for GH-859
504680e
Linting.
b16336d
Change to be able to run unit tests on Windows.
181ebd8
add CODEOWNERS file
christophertino a22b090
Merge branch 'develop' into feature/gh-859
christophertino 4bcdb53
Merge pull request #1 from ghostery/feature/gh-859
christophertino 8318f2c
Fixes for GH-869, GH-870.
c3fb116
Merge remote-tracking branch 'upstream/develop' into develop
eb3baea
Fix for GH-872
9680394
Fixing lint errors.
2de44bb
Adding callouts for tooltips.
e6b768e
Merge pull request #5 from zarembsky/develop
christophertino 1a22cd7
Merge branch 'master' into develop
christophertino 21c1015
Refactoring loading cliqz modules. Fixing GH-476.
94a85b7
Merge remote-tracking branch 'upstream/develop' into develop
715aa62
Removing old code.
3297c98
Removing isReady.
d848377
Merge pull request #8 from zarembsky/develop
jsignanini b800e72
removing background log that broke extension loading
christophertino 135777a
First pass at the updated simple view
IAmThePan bdcba81
Fix for GH-877, GH-886, GH-872.
765f56d
Merge remote-tracking branch 'upstream/develop' into develop
95b400f
Removing log from manifest
636c05c
Added return after reject.
9f88345
Merge pull request #9 from zarembsky/develop
jsignanini 54b5286
Adding return after rejects in a few places.
6078357
Implementing flag for site-specific unblocks.
c81bd41
Using abbreviations for seconds, removing unnecessary comment.
0745205
Requested changes.
61a1e5c
Implementing suggested changes.
40c1d48
Update policy block reason name.
jsignanini 6bf01a9
Update block reason names. Call allowedOnce check only when needed.
jsignanini 6ee32ae
Update JSDocs and add missing block reason.
jsignanini b523b46
Update JSDocs and update block reason c2p names.
jsignanini 73cc0eb
Fix typo.
jsignanini 3db6b2b
Merge pull request #10 from zarembsky/develop
jsignanini 587568e
Added checks for non-null message
adfb1e4
add NO_LINT env option
trickpattyFH20 6164935
use npm ci(continuous integration) install command per npm 5.7.1
trickpattyFH20 cf201b5
Merge pull request #14 from trickpattyFH20/develop
christophertino dde6adb
Fixing GH-872
1805ed0
Updated simple view and detailed expert and condensed views.
IAmThePan 9748fa9
initial webpack 4 build
trickpattyFH20 37e6e2e
Merge branch 'develop' into feature/webpack-4-upgrade
christophertino ce103eb
Merge pull request #16 from trickpattyFH20/feature/webpack-4-upgrade
christophertino 09e4d41
make pattern matcher case insensitive + unit test
christophertino e81002e
fix redux actions with missing returns in setup app
christophertino 7e6a6a4
remove verbose webpack output
trickpattyFH20 189fa1d
add verbose to build.watch
trickpattyFH20 d39176f
Merge branch 'develop' into feature/webpack-4-upgrade
christophertino af508ce
Optimize tooltips and notifications
IAmThePan ad33142
Merge pull request #18 from trickpattyFH20/feature/webpack-4-upgrade
jsignanini 4aa116b
update CONTRIBUTING to allow patches via email. Fixes #6
christophertino e4887b4
Fix linting errors
IAmThePan 3bbdfe5
fix lint on change regression
trickpattyFH20 a5dfd69
output lint after webpack output
trickpattyFH20 c13afec
done rr
trickpattyFH20 d686bae
Add jest tests for PauseButton.jxs
IAmThePan 355487e
Changes in response to PR requested changes.
9f76c0c
GH-863 update tooltip and notification logic
IAmThePan 9036eaf
GH-876 updated header tabs
IAmThePan b896758
GH-867 update alternate POC
IAmThePan 523cbcb
Merge pull request #20 from trickpattyFH20/feature/fix-lint-on-change
jsignanini 6e62d5f
Requested changes.
795a120
Merge remote-tracking branch 'upstream/develop' into develop
2c66dfc
Merge pull request #15 from zarembsky/develop
jsignanini 865bc1f
GH-888 updated pause button location and tooltips
IAmThePan c7ccfac
upgrade webpack and fix watch scss bug
trickpattyFH20 3d09a37
GH-908 Un-swapped text on cliqz-features page on setup flow
IAmThePan df32e54
fix watch lint scss
trickpattyFH20 03a6be5
Merge pull request #26 from trickpattyFH20/develop
jsignanini 8474938
Merge branch 'develop' into gh-908
jsignanini 7c4d58f
Merge pull request #27 from IAmThePan/gh-908
jsignanini 9824b00
Set default Summary to new Pause Button position
IAmThePan 7553c2a
update package-lock file
IAmThePan fb078cd
Merge Simple View changes into Develop
IAmThePan c30cef1
Fix linting errors
IAmThePan ab78614
Fix error where panel wasn't displaying
IAmThePan 78f04ae
Fix jsdoc issues
IAmThePan 61ce7be
check for chrome newtab before calling injectScript
christophertino b9cdcd3
Merge pull request #25 from IAmThePan/simple-view-merge
jsignanini 9b2ed2e
cleanup extraneous object property checks
christophertino cada891
Merge branch 'feature/newtab_check' into develop
christophertino 3f48081
udpate docs
christophertino 2b12a89
Create pipeline steps to control whitelisting of antitracking and adb…
sammacbeth 05ceff9
Update Cliqz bundle to 1.26.1
sammacbeth 82d8b4b
WIP nightly builds on jenkins
sammacbeth c431b0e
Merge pull request #23 from sammacbeth/cliqz-whitelisting-actions
jsignanini ebdfaa0
Publish with build number.
sammacbeth 7718afe
Use package-lock.json in docker.
sammacbeth 924458a
Test moab makezip
sammacbeth cfc2f0f
WIP fetch up-to-date libraries for build.
sammacbeth 6db0d29
Add option to build with browser-core master
sammacbeth 15e9f78
Add signing step.
sammacbeth 9697aae
Panel Fixes: Fix CSS SVG encoding for FF
IAmThePan 58e8816
Panel Fixes: HTML encode inline SVGs
IAmThePan bf28571
Panel Fixes: Edge bug fixes (GH-911)
IAmThePan 08fc2da
GH-867 Alternate Summary View AB Test
IAmThePan 0266a29
Fix overflow scroll issue
IAmThePan d30db63
Toggle Summary AB test off
IAmThePan 99d9bec
Merge pull request #28 from IAmThePan/develop
jsignanini f1b7132
Fix tooltip scroll issue
IAmThePan 66426bd
Merge remote-tracking branch 'upstream/develop' into develop
IAmThePan 24d8cbc
Make browser-core log.
sammacbeth bfb625f
Merge pull request #29 from IAmThePan/develop
jsignanini ed78465
adding utm check to ghostery.com
christophertino 07a7569
Load github credentials to enable moab checkout of ghostery-libraries.
sammacbeth af79226
Tidy deployment.
sammacbeth e071f77
Add Chrome packaging step.
sammacbeth e8c74b9
Merge branch 'develop' into nightly
christophertino 1836775
Merge pull request #32 from sammacbeth/nightly
christophertino 48b74b0
GH-862: Unit tests for the Panel (#31)
IAmThePan f559662
Publish beta builds for cliqz and chrome. (#33)
sammacbeth a901ce8
Fix for Ghostery in Cliqz issues (#37)
3585107
update changelog and bump version
christophertino 09b9cd1
GH-955: Update Smart Blocking icon on Tracker List
IAmThePan 6f64bc1
GH-954: Fix spelling error for Anti-Tracking ON notification
IAmThePan f810d7d
GH-953 fix bug where pause button is off by 1px
IAmThePan 5fc5e22
bump browser-core version
christophertino 46f7ce1
add minimum_opera_version to manifest
christophertino 5fa827f
integrity check browser-core workaround (#45)
trickpattyFH20 f9f2680
Fix for GH-952 (#40)
83003f5
omit firefox about:pages from content script injection
christophertino 5323f08
Smart Block: Don't block mixed content from localhost. Fixes #44 and …
christophertino 84cf489
GH-1021 Add browser version to metrics
christophertino f00e1f9
GH-889 limit send of utm_source and utm_campaign metrics
christophertino 86625ac
Updated webpack
df10b3d
Fixes for GH-1001 and GH-1022
Closed
Fixes for metrics bugs GH-1001 and GH-1022 #46
Load github credentials to enable moab checkout of ghostery-libraries.
Mar 8, 2018
Mar 8, 2018
Mar 8, 2018
Mar 8, 2018
Mar 8, 2018
Mar 9, 2018
Mar 12, 2018
Mar 12, 2018
Mar 13, 2018
Mar 13, 2018
Mar 14, 2018
Mar 15, 2018
Mar 15, 2018
Mar 16, 2018
Mar 16, 2018
Mar 19, 2018
Mar 19, 2018
Mar 19, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 20, 2018
Mar 22, 2018
Mar 22, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 23, 2018
Mar 26, 2018
Mar 27, 2018
Mar 27, 2018
Mar 27, 2018
Mar 28, 2018
Mar 28, 2018
Mar 28, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 29, 2018
Mar 30, 2018
Mar 30, 2018
Mar 30, 2018
Mar 30, 2018
Apr 2, 2018
Apr 2, 2018
Apr 2, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 3, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Apr 4, 2018
Mar 26, 2018
Apr 3, 2018
Apr 5, 2018
Apr 5, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 6, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 9, 2018
Apr 10, 2018
Apr 10, 2018
Apr 10, 2018
Apr 10, 2018
Apr 10, 2018
Apr 12, 2018
Apr 12, 2018
Apr 13, 2018
Apr 18, 2018
Apr 17, 2018
Apr 17, 2018
Apr 18, 2018
Apr 19, 2018
Apr 19, 2018
Apr 23, 2018
Apr 23, 2018
Apr 24, 2018
Apr 24, 2018
Apr 25, 2018
Apr 25, 2018
Apr 26, 2018
Apr 26, 2018
07a7569
Select commit
262ca37
Fix for GH-859
504680e
Linting.
b16336d
Change to be able to run unit tests on Windows.
181ebd8
add CODEOWNERS file
christophertino a22b090
Merge branch 'develop' into feature/gh-859
christophertino 4bcdb53
Merge pull request #1 from ghostery/feature/gh-859
christophertino 8318f2c
Fixes for GH-869, GH-870.
c3fb116
Merge remote-tracking branch 'upstream/develop' into develop
eb3baea
Fix for GH-872
9680394
Fixing lint errors.
2de44bb
Adding callouts for tooltips.
e6b768e
Merge pull request #5 from zarembsky/develop
christophertino 1a22cd7
Merge branch 'master' into develop
christophertino 21c1015
Refactoring loading cliqz modules. Fixing GH-476.
94a85b7
Merge remote-tracking branch 'upstream/develop' into develop
715aa62
Removing old code.
3297c98
Removing isReady.
d848377
Merge pull request #8 from zarembsky/develop
jsignanini b800e72
removing background log that broke extension loading
christophertino 135777a
First pass at the updated simple view
IAmThePan bdcba81
Fix for GH-877, GH-886, GH-872.
765f56d
Merge remote-tracking branch 'upstream/develop' into develop
95b400f
Removing log from manifest
636c05c
Added return after reject.
9f88345
Merge pull request #9 from zarembsky/develop
jsignanini 54b5286
Adding return after rejects in a few places.
6078357
Implementing flag for site-specific unblocks.
c81bd41
Using abbreviations for seconds, removing unnecessary comment.
0745205
Requested changes.
61a1e5c
Implementing suggested changes.
40c1d48
Update policy block reason name.
jsignanini 6bf01a9
Update block reason names. Call allowedOnce check only when needed.
jsignanini 6ee32ae
Update JSDocs and add missing block reason.
jsignanini b523b46
Update JSDocs and update block reason c2p names.
jsignanini 73cc0eb
Fix typo.
jsignanini 3db6b2b
Merge pull request #10 from zarembsky/develop
jsignanini 587568e
Added checks for non-null message
adfb1e4
add NO_LINT env option
trickpattyFH20 6164935
use npm ci(continuous integration) install command per npm 5.7.1
trickpattyFH20 cf201b5
Merge pull request #14 from trickpattyFH20/develop
christophertino dde6adb
Fixing GH-872
1805ed0
Updated simple view and detailed expert and condensed views.
IAmThePan 9748fa9
initial webpack 4 build
trickpattyFH20 37e6e2e
Merge branch 'develop' into feature/webpack-4-upgrade
christophertino ce103eb
Merge pull request #16 from trickpattyFH20/feature/webpack-4-upgrade
christophertino 09e4d41
make pattern matcher case insensitive + unit test
christophertino e81002e
fix redux actions with missing returns in setup app
christophertino 7e6a6a4
remove verbose webpack output
trickpattyFH20 189fa1d
add verbose to build.watch
trickpattyFH20 d39176f
Merge branch 'develop' into feature/webpack-4-upgrade
christophertino af508ce
Optimize tooltips and notifications
IAmThePan ad33142
Merge pull request #18 from trickpattyFH20/feature/webpack-4-upgrade
jsignanini 4aa116b
update CONTRIBUTING to allow patches via email. Fixes #6
christophertino e4887b4
Fix linting errors
IAmThePan 3bbdfe5
fix lint on change regression
trickpattyFH20 a5dfd69
output lint after webpack output
trickpattyFH20 c13afec
done rr
trickpattyFH20 d686bae
Add jest tests for PauseButton.jxs
IAmThePan 355487e
Changes in response to PR requested changes.
9f76c0c
GH-863 update tooltip and notification logic
IAmThePan 9036eaf
GH-876 updated header tabs
IAmThePan b896758
GH-867 update alternate POC
IAmThePan 523cbcb
Merge pull request #20 from trickpattyFH20/feature/fix-lint-on-change
jsignanini 6e62d5f
Requested changes.
795a120
Merge remote-tracking branch 'upstream/develop' into develop
2c66dfc
Merge pull request #15 from zarembsky/develop
jsignanini 865bc1f
GH-888 updated pause button location and tooltips
IAmThePan c7ccfac
upgrade webpack and fix watch scss bug
trickpattyFH20 3d09a37
GH-908 Un-swapped text on cliqz-features page on setup flow
IAmThePan df32e54
fix watch lint scss
trickpattyFH20 03a6be5
Merge pull request #26 from trickpattyFH20/develop
jsignanini 8474938
Merge branch 'develop' into gh-908
jsignanini 7c4d58f
Merge pull request #27 from IAmThePan/gh-908
jsignanini 9824b00
Set default Summary to new Pause Button position
IAmThePan 7553c2a
update package-lock file
IAmThePan fb078cd
Merge Simple View changes into Develop
IAmThePan c30cef1
Fix linting errors
IAmThePan ab78614
Fix error where panel wasn't displaying
IAmThePan 78f04ae
Fix jsdoc issues
IAmThePan 61ce7be
check for chrome newtab before calling injectScript
christophertino b9cdcd3
Merge pull request #25 from IAmThePan/simple-view-merge
jsignanini 9b2ed2e
cleanup extraneous object property checks
christophertino cada891
Merge branch 'feature/newtab_check' into develop
christophertino 3f48081
udpate docs
christophertino 2b12a89
Create pipeline steps to control whitelisting of antitracking and adb…
sammacbeth 05ceff9
Update Cliqz bundle to 1.26.1
sammacbeth 82d8b4b
WIP nightly builds on jenkins
sammacbeth c431b0e
Merge pull request #23 from sammacbeth/cliqz-whitelisting-actions
jsignanini ebdfaa0
Publish with build number.
sammacbeth 7718afe
Use package-lock.json in docker.
sammacbeth 924458a
Test moab makezip
sammacbeth cfc2f0f
WIP fetch up-to-date libraries for build.
sammacbeth 6db0d29
Add option to build with browser-core master
sammacbeth 15e9f78
Add signing step.
sammacbeth 9697aae
Panel Fixes: Fix CSS SVG encoding for FF
IAmThePan 58e8816
Panel Fixes: HTML encode inline SVGs
IAmThePan bf28571
Panel Fixes: Edge bug fixes (GH-911)
IAmThePan 08fc2da
GH-867 Alternate Summary View AB Test
IAmThePan 0266a29
Fix overflow scroll issue
IAmThePan d30db63
Toggle Summary AB test off
IAmThePan 99d9bec
Merge pull request #28 from IAmThePan/develop
jsignanini f1b7132
Fix tooltip scroll issue
IAmThePan 66426bd
Merge remote-tracking branch 'upstream/develop' into develop
IAmThePan 24d8cbc
Make browser-core log.
sammacbeth bfb625f
Merge pull request #29 from IAmThePan/develop
jsignanini ed78465
adding utm check to ghostery.com
christophertino 07a7569
Load github credentials to enable moab checkout of ghostery-libraries.
sammacbeth af79226
Tidy deployment.
sammacbeth e071f77
Add Chrome packaging step.
sammacbeth e8c74b9
Merge branch 'develop' into nightly
christophertino 1836775
Merge pull request #32 from sammacbeth/nightly
christophertino 48b74b0
GH-862: Unit tests for the Panel (#31)
IAmThePan f559662
Publish beta builds for cliqz and chrome. (#33)
sammacbeth a901ce8
Fix for Ghostery in Cliqz issues (#37)
3585107
update changelog and bump version
christophertino 09b9cd1
GH-955: Update Smart Blocking icon on Tracker List
IAmThePan 6f64bc1
GH-954: Fix spelling error for Anti-Tracking ON notification
IAmThePan f810d7d
GH-953 fix bug where pause button is off by 1px
IAmThePan 5fc5e22
bump browser-core version
christophertino 46f7ce1
add minimum_opera_version to manifest
christophertino 5fa827f
integrity check browser-core workaround (#45)
trickpattyFH20 f9f2680
Fix for GH-952 (#40)
83003f5
omit firefox about:pages from content script injection
christophertino 5323f08
Smart Block: Don't block mixed content from localhost. Fixes #44 and …
christophertino 84cf489
GH-1021 Add browser version to metrics
christophertino f00e1f9
GH-889 limit send of utm_source and utm_campaign metrics
christophertino 86625ac
Updated webpack
df10b3d
Fixes for GH-1001 and GH-1022