GH-1774/In-App Insights Promo #460
Merged
Conversation
… days. Users subscribed to insights will not be shown promos.
… to log in on summary page.
…essages. Add check icon to plus promo modal. Modify plus promo modal css.
…rendering in panel. Implement display context CSS adjustments.
… Begin to implement conditional panel display logic
…ed business logic and state management
…dismisses promo panel. Send record of promo interaction to background
…ional rendering logic to account for upgrade version of modal
…ion and add debug code
* Show plus promo modal on first view of Home view of each Hub session * Stub out intro hub plus promo modal layout and implement its buttons * Remove some unnecessary plus promo modal related CSS * Continue adding styling for plus promo modal * Continue styling plus promo modal * Refactor plus promo modal CSS to improve alignment of elements * Continue CSS work for plus promo modal * Implement recommended gold banner in plus promo modal * Update and tweak plus promo modal design * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css. * Additional consolidation of redundant and unused entries in messages * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments. * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic * Create ModalPromos background class responsible for modal promo related business logic and state management * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background * Make PromoModals code more robust * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments. * Clean up. Finish string localization in PlusPromoModal * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify * Remove debug console statement
* Add language and toggle for notify_promotions * Change label name
benstrumeyer
requested review from
jsignanini,
zarembsky and
ghostery/ghostery
as
code owners
|
Review in progress |
app/shared-components/InsightsPromoModal/InsightsPromoModal.jsx
Outdated
Show resolved
Hide resolved
app/shared-components/InsightsPromoModal/InsightsPromoModal.scss
Outdated
Show resolved
Hide resolved
app/shared-components/InsightsPromoModal/InsightsPromoModal.scss
Outdated
Show resolved
Hide resolved
christophertino
added a commit
that referenced
this pull request
Oct 28, 2019
* Created modal UI * Change feature language. Add exit button. * Add insights modal that will appear if a user clicks 3x per day for 3 days. Users subscribed to insights will not be shown promos. * Refactor insights modal into a component. Reshow modal after prompted to log in on summary page. * Clean up insights modal code * Show plus promo modal on first view of Home view of each Hub session * Stub out intro hub plus promo modal layout and implement its buttons * Remove some unnecessary plus promo modal related CSS * Continue adding styling for plus promo modal * Continue styling plus promo modal * Refactor plus promo modal CSS to improve alignment of elements * Continue CSS work for plus promo modal * Implement recommended gold banner in plus promo modal * Update and tweak plus promo modal design * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css. * Additional consolidation of redundant and unused entries in messages * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments. * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic * Create ModalPromos background class responsible for modal promo related business logic and state management * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background * Make PromoModals code more robust * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments. * Clean up. Finish string localization in PlusPromoModal * Plug in insights modal into promo modal class * GH-1777 and GH-1776 Plus Promo modals (#458) * Show plus promo modal on first view of Home view of each Hub session * Stub out intro hub plus promo modal layout and implement its buttons * Remove some unnecessary plus promo modal related CSS * Continue adding styling for plus promo modal * Continue styling plus promo modal * Refactor plus promo modal CSS to improve alignment of elements * Continue CSS work for plus promo modal * Implement recommended gold banner in plus promo modal * Update and tweak plus promo modal design * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css. * Additional consolidation of redundant and unused entries in messages * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments. * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic * Create ModalPromos background class responsible for modal promo related business logic and state management * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background * Make PromoModals code more robust * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments. * Clean up. Finish string localization in PlusPromoModal * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify * Remove debug console statement * Consolidate insights promo with plus promo * GH-1814/promo toggle (#453) * Add language and toggle for notify_promotions * Change label name * User can opt out of promotions * Remove empty SCSS class * Add newlines * Add hover effects * Refactor insights promo to use redux. Remove summary component code. Remove redundant scss rules. * Refactor hasEngagedFrequently to update in recordEngaged * Refactor recordEngaged * Fix recordEngaged bug * Fix font paths * Remove unused font asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Implements the UI and business logic for the Insights Promo modal described in GH-1774 and GH-1814 (Promotion opt-out). Relies on PromoModals.js class in GH-1777 and GH-1776. Does not implement the exception for triggering Insights during the first month of usage. This feature will be added in a separate PR.