New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1774/In-App Insights Promo #460
Commits on Oct 18, 2019
Add insights modal that will appear if a user clicks 3x per day for 3…
… days. Users subscribed to insights will not be shown promos.
Refactor insights modal into a component. Reshow modal after prompted…
… to log in on summary page.
Fix path bug in i18n-checker tool. Consolidate redundant entries in m…
…essages. Add check icon to plus promo modal. Modify plus promo modal css.
Factor plus promo modal rendering out to shared component. Implement …
…rendering in panel. Implement display context CSS adjustments.
Move Plus Promo modal rendering to a PlusPromoModal shared component.…
… Begin to implement conditional panel display logic
Create ModalPromos background class responsible for modal promo relat…
…ed business logic and state management
Add local state to Panel to make sure component rerenders after user …
…dismisses promo panel. Send record of promo interaction to background
Factor PlusPromoModal rendering out to helper in Panel. Extend condit…
…ional rendering logic to account for upgrade version of modal
Mark PromoModals methods as static. Refine PlusPromoModal implementat…
…ion and add debug code
GH-1777 and GH-1776 Plus Promo modals (#458)
* Show plus promo modal on first view of Home view of each Hub session * Stub out intro hub plus promo modal layout and implement its buttons * Remove some unnecessary plus promo modal related CSS * Continue adding styling for plus promo modal * Continue styling plus promo modal * Refactor plus promo modal CSS to improve alignment of elements * Continue CSS work for plus promo modal * Implement recommended gold banner in plus promo modal * Update and tweak plus promo modal design * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css. * Additional consolidation of redundant and unused entries in messages * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments. * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic * Create ModalPromos background class responsible for modal promo related business logic and state management * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background * Make PromoModals code more robust * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments. * Clean up. Finish string localization in PlusPromoModal * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify * Remove debug console statement
* Add language and toggle for notify_promotions * Change label name