M20-52: Full takeover of Ghostery rewards #462
Merged
+390
−3,921
Conversation
aleksandr-cliqz
requested review from
christophertino,
jsignanini,
wlycdgr,
zarembsky and
ghostery/ghostery
as
code owners
|
Remove unused package: |
|
lets keep only en translations |
added 19 commits
Oct 11, 2019
aleksandr-cliqz
force-pushed the
aleksandr-cliqz:M20-52_takeover_of_ghostery_rewards
branch
from
b9a7ec5
to
9d67f42
|
|
|
@aleksandr-cliqz Looks good to me. Once we get the new browser-core build added we can merge it up. |
aleksandr-cliqz
force-pushed the
aleksandr-cliqz:M20-52_takeover_of_ghostery_rewards
branch
from
d93bd11
to
2a23dbd
added 4 commits
Nov 18, 2019
… M20-52_takeover_of_ghostery_rewards
… M20-52_takeover_of_ghostery_rewards
|
@christophertino could you help me plz with continuous-integration/travis-ci/pr ? UPD: Chris, thank you |
|
@christophertino |
… M20-52_takeover_of_ghostery_rewards
christophertino
merged commit c14d10f
into
ghostery:develop
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://cliqztix.atlassian.net/browse/M20-52
@luciancor @christophertino @sammacbeth @olpa-cliqz
Description:
the main idea to show myoffrz-rewards instead of ghostery-rewards in ghostery-extension.
Navigation-extension: we treat ghostery as whitelabel extension (see e.g. chip extension)
Ghostery-extension: we reuse in content-script cliqz-bundle (with myoffrz-rewards) and show list of rewards in ghostery-cc; we will use iframe to show list of rewards.
Locales:
There are around 45 keys in the pull-request. Some of them new, some renamed to follow convension (prefix myoffrz_) English: all keys, Poland: around 20 renamed, other countries: will be addressed in next prs