Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery Plus & Insights Promo Modals #464

Merged
merged 13 commits into from Oct 28, 2019
Merged

Ghostery Plus & Insights Promo Modals #464

merged 13 commits into from Oct 28, 2019

Commits on Oct 16, 2019

  1. GH-1777 and GH-1776 Plus Promo modals (#458)

    * Show plus promo modal on first view of Home view of each Hub session
    
    * Stub out intro hub plus promo modal layout and implement its buttons
    
    * Remove some unnecessary plus promo modal related CSS
    
    * Continue adding styling for plus promo modal
    
    * Continue styling plus promo modal
    
    * Refactor plus promo modal CSS to improve alignment of elements
    
    * Continue CSS work for plus promo modal
    
    * Implement recommended gold banner in plus promo modal
    
    * Update and tweak plus promo modal design
    
    * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.
    
    * Additional consolidation of redundant and unused entries in messages
    
    * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.
    
    * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic
    
    * Create ModalPromos background class responsible for modal promo related business logic and state management
    
    * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background
    
    * Make PromoModals code more robust
    
    * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal
    
    * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code
    
    * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.
    
    * Clean up. Finish string localization in PlusPromoModal
    
    * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify
    
    * Remove debug console statement
    wlycdgr committed Oct 16, 2019

Commits on Oct 18, 2019

  1. GH-1814/promo toggle (#453)

    * Add language and toggle for notify_promotions
    
    * Change label name
    benstrumeyer authored and wlycdgr committed Oct 18, 2019

Commits on Oct 24, 2019

  1. GH-1774/In-App Insights Promo (#460)

    * Created modal UI
    
    * Change feature language. Add exit button.
    
    * Add insights modal that will appear if a user clicks 3x per day for 3 days. Users subscribed to insights will not be shown promos.
    
    * Refactor insights modal into a component. Reshow modal after prompted to log in on summary page.
    
    * Clean up insights modal code
    
    * Show plus promo modal on first view of Home view of each Hub session
    
    * Stub out intro hub plus promo modal layout and implement its buttons
    
    * Remove some unnecessary plus promo modal related CSS
    
    * Continue adding styling for plus promo modal
    
    * Continue styling plus promo modal
    
    * Refactor plus promo modal CSS to improve alignment of elements
    
    * Continue CSS work for plus promo modal
    
    * Implement recommended gold banner in plus promo modal
    
    * Update and tweak plus promo modal design
    
    * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.
    
    * Additional consolidation of redundant and unused entries in messages
    
    * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.
    
    * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic
    
    * Create ModalPromos background class responsible for modal promo related business logic and state management
    
    * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background
    
    * Make PromoModals code more robust
    
    * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal
    
    * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code
    
    * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.
    
    * Clean up. Finish string localization in PlusPromoModal
    
    * Plug in insights modal into promo modal class
    
    * GH-1777 and GH-1776 Plus Promo modals (#458)
    
    * Show plus promo modal on first view of Home view of each Hub session
    
    * Stub out intro hub plus promo modal layout and implement its buttons
    
    * Remove some unnecessary plus promo modal related CSS
    
    * Continue adding styling for plus promo modal
    
    * Continue styling plus promo modal
    
    * Refactor plus promo modal CSS to improve alignment of elements
    
    * Continue CSS work for plus promo modal
    
    * Implement recommended gold banner in plus promo modal
    
    * Update and tweak plus promo modal design
    
    * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.
    
    * Additional consolidation of redundant and unused entries in messages
    
    * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.
    
    * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic
    
    * Create ModalPromos background class responsible for modal promo related business logic and state management
    
    * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background
    
    * Make PromoModals code more robust
    
    * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal
    
    * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code
    
    * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.
    
    * Clean up. Finish string localization in PlusPromoModal
    
    * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify
    
    * Remove debug console statement
    
    * Consolidate insights promo with plus promo
    
    * GH-1814/promo toggle (#453)
    
    * Add language and toggle for notify_promotions
    
    * Change label name
    
    * User can opt out of promotions
    
    * Remove empty SCSS class
    
    * Add newlines
    
    * Add hover effects
    
    * Refactor insights promo to use redux. Remove summary component code. Remove redundant scss rules.
    
    * Refactor hasEngagedFrequently to update in recordEngaged
    
    * Refactor recordEngaged
    
    * Fix recordEngaged bug
    
    * Fix font paths
    
    * Remove unused font asset
    benstrumeyer authored and wlycdgr committed Oct 24, 2019
  2. Gh 1813/feature/in app plus promo upgrade (#463)

    * Show plus promo modal on first view of Home view of each Hub session
    
    * Stub out intro hub plus promo modal layout and implement its buttons
    
    * Remove some unnecessary plus promo modal related CSS
    
    * Continue adding styling for plus promo modal
    
    * Continue styling plus promo modal
    
    * Refactor plus promo modal CSS to improve alignment of elements
    
    * Continue CSS work for plus promo modal
    
    * Implement recommended gold banner in plus promo modal
    
    * Update and tweak plus promo modal design
    
    * Fix path bug in i18n-checker tool. Consolidate redundant entries in messages. Add check icon to plus promo modal. Modify plus promo modal css.
    
    * Additional consolidation of redundant and unused entries in messages
    
    * Factor plus promo modal rendering out to shared component. Implement rendering in panel. Implement display context CSS adjustments.
    
    * Move Plus Promo modal rendering to a PlusPromoModal shared component. Begin to implement conditional panel display logic
    
    * Create ModalPromos background class responsible for modal promo related business logic and state management
    
    * Add local state to Panel to make sure component rerenders after user dismisses promo panel. Send record of promo interaction to background
    
    * Make PromoModals code more robust
    
    * Factor PlusPromoModal rendering out to helper in Panel. Extend conditional rendering logic to account for upgrade version of modal
    
    * Mark PromoModals methods as static. Refine PlusPromoModal implementation and add debug code
    
    * Add logic to hide plus promo modal from Insights subscribers. Cleanup and comments.
    
    * Clean up. Finish string localization in PlusPromoModal
    
    * Add gold ghostie badge svg. Begin fleshing out upgrade plus promo modal design
    
    * Pull non-shared upgrade version of plus promo modal out of shared PlusPromoModal component and into Panel to simplify
    
    * Flesh out upgrade promo modal UI and styles
    
    * Implement panel to tab link for the upgrade to plus button
    
    * Add no thanks link click handling
    
    * Localization-proof upgrade modal CSS. Finalize UI and display logic.
    
    * Implement ability to turn off promotions from inside plus upgrade promo modal
    wlycdgr committed Oct 24, 2019
  3. Prioritize showing Insights upgrade promo over Plus upgrade promo whe…

    …n conditions for both are met
    wlycdgr committed Oct 24, 2019

Commits on Oct 25, 2019

  1. Make sure we only repop modals after login through modal if user does…

    … not have appropriate sub(s)
    wlycdgr committed Oct 25, 2019
  2. Add X icon to Upgrade variant of Plus Promo Modal. Factor rendering o…

    …f that modal out to a component analogous to InsightsPromoModal. Clean up click handling for both promo modals.
    wlycdgr committed Oct 25, 2019
  3. Insights modal css bug fix

    wlycdgr committed Oct 25, 2019

Commits on Oct 28, 2019

  1. Fix background message handler return values for promos. Add license …

    …and header to Plus Promo Modal sass file.
    wlycdgr committed Oct 28, 2019