Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery Plus & Insights Promo Modals #464

Merged
merged 13 commits into from Oct 28, 2019
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev

Fix background message handler return values for promos. Add license …

…and header to Plus Promo Modal sass file.
  • Loading branch information
wlycdgr committed Oct 28, 2019
commit 82b4d049595b7dbf46c0e530b7af1437c28668c7
@@ -1,3 +1,17 @@
/**
* Plus Promo Modal Sass
*
* Ghostery Browser Extension
* https://www.ghostery.com/
*
* Copyright 2019 Ghostery, Inc. All rights reserved.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0
*/

// Plus Promo Modal
$standard-font-family: Roboto, "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
This conversation was marked as resolved by christophertino

This comment has been minimized.

@christophertino

christophertino Oct 26, 2019
Member

Add a document header / license notice

This comment has been minimized.

@wlycdgr

wlycdgr Oct 28, 2019
Author Member

Done


.PlusPromoModal__gold-ghostie-badge {
@@ -1080,15 +1080,15 @@ function onMessageHandler(request, sender, callback) {
}
if (name === 'promoModals.sawPlusPromo') {
promoModals.recordPlusPromoSighting();
return true;
return false;
}
if (name === 'promoModals.sawInsightsPromo') {
promoModals.recordInsightsPromoSighting();
return true;
return false;
}
if (name === 'promoModals.turnOffPromos') {
promoModals.turnOffPromos();
return true;
return false;
}
}

ProTip! Use n and p to navigate between commits in a pull request.