Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostery Plus & Insights Promo Modals #464

Merged
merged 13 commits into from Oct 28, 2019
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Make sure opting out of promos through the modals is persisted to acc…

…ount
  • Loading branch information
wlycdgr committed Oct 25, 2019
commit d897248aaafb78b516339775be88c002fd8c071a
@@ -13,6 +13,7 @@

import conf from './Conf';
import globals from './Globals';
import panelData from './PanelData';

const DAYS_BETWEEN_PROMOS = {
plus: globals.DEBUG ? 0.00025 : 30,
@@ -49,7 +50,7 @@ class PromoModals {

static recordInsightsPromoSighting() { this._recordPromoSighting(INSIGHTS); }

static turnOffPromos() { conf.notify_promotions = false; }
static turnOffPromos() { panelData.set({ notify_promotions: false }); }

static _haveSeenInitialPlusPromo() {
const lastSeenTime = conf[`${PLUS}_${PROMO_MODAL_LAST_SEEN}`];
ProTip! Use n and p to navigate between commits in a pull request.