Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghostery Plus & Insights Promo Modals #464

Merged
merged 13 commits into from Oct 28, 2019
+1,766 −583
Merged

Ghostery Plus & Insights Promo Modals #464

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b3856d2
GH-1777 and GH-1776 Plus Promo modals (#458)
wlycdgr Oct 16, 2019
e47a0c3
GH-1814/promo toggle (#453)
benstrumeyer Oct 18, 2019
6e6c8d3
GH-1774/In-App Insights Promo (#460)
benstrumeyer Oct 24, 2019
e960dc7
Gh 1813/feature/in app plus promo upgrade (#463)
wlycdgr Oct 24, 2019
93369c8
Prioritize showing Insights upgrade promo over Plus upgrade promo whe…
wlycdgr Oct 24, 2019
27189bc
Make sure we only repop modals after login through modal if user does…
wlycdgr Oct 25, 2019
932156b
Add X icon to Upgrade variant of Plus Promo Modal. Factor rendering o…
wlycdgr Oct 25, 2019
a2051f7
Insights modal css bug fix
wlycdgr Oct 25, 2019
afc4c40
Do not use production checkout links on staging for the insights and …
wlycdgr Oct 25, 2019
d897248
Make sure opting out of promos through the modals is persisted to acc…
wlycdgr Oct 25, 2019
da56279
Debug and clean up PlusPromoModal shared component
wlycdgr Oct 25, 2019
f2dceec
Fix click handling css bug in Plus Upgrade Promo Modal
wlycdgr Oct 25, 2019
82b4d04
Fix background message handler return values for promos. Add license …
wlycdgr Oct 28, 2019
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Fix click handling css bug in Plus Upgrade Promo Modal

  • Loading branch information
@wlycdgr
wlycdgr committed Oct 25, 2019
commit f2dceec0cb29a71efdfebbc30c7783e5e48194f0
4 app/panel/components/PlusUpgradePromoModal.jsx
View file
Open in desktop
@@ -60,8 +60,8 @@ class PlusUpgradePromoModal extends React.Component {
<div className="PlusPromoModal__description cta">
{t('upgrade_cta_TEXT')}
</div>
<div className="PlusPromoModal__button-container" onClick={this.handleSubscribeClick}>
<PanelToTabLink className="PlusPromoModal__button upgrade" href={`http://checkout.${DOMAIN}.com/plus/`}>
<div className="PlusPromoModal__button-container">
<PanelToTabLink onClick={this.handleSubscribeClick} className="PlusPromoModal__button upgrade" href={`http://checkout.${DOMAIN}.com/plus/`}>
<span className="button-text">{t('upgrade_to_plus')}</span>
</PanelToTabLink>
</div>
ProTip! Use n and p to navigate between commits in a pull request.