Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 1775/feature/promo modal metrics pings #466

Merged
merged 4 commits into from Oct 28, 2019
Merged

Gh 1775/feature/promo modal metrics pings #466

merged 4 commits into from Oct 28, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 28, 2019

Implements Plus and Insights promo modal metrics pings. Details in GH-1775.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Add promo modal metrics pings as per GH-1775
Loading status checks…
51a9333
@wlycdgr wlycdgr requested review from christophertino, Eden12345, jsignanini, zarembsky and ghostery/ghostery as code owners Oct 28, 2019
@christophertino christophertino changed the base branch from master to develop Oct 28, 2019
@christophertino
Merge branch 'develop' into GH-1775/feature/promo-modal-metrics-pings
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
98bbefa
@christophertino christophertino added this to the 8.4.4 milestone Oct 28, 2019
@christophertino
christophertino requested changes Oct 28, 2019
View changes
app/panel/components/Panel.jsx Outdated Show resolved Hide resolved
app/panel/components/Panel.jsx Outdated Show resolved Hide resolved
wlycdgr added 2 commits Oct 28, 2019
@wlycdgr
Remove some unused arguments and imports and outdated comments
8f71086
@wlycdgr
Merge branch 'GH-1775/feature/promo-modal-metrics-pings' of github.co…
Loading status checks…
a29d7c9 
…m:ghostery/ghostery-extension into GH-1775/feature/promo-modal-metrics-pings
@christophertino
christophertino approved these changes Oct 28, 2019
View changes
@christophertino christophertino merged commit c9370bc into develop Oct 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1775/feature/promo-modal-metrics-pings branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino