Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 1871/promo modal opt out notification #467

Merged
merged 2 commits into from Oct 28, 2019
Merged

Gh 1871/promo modal opt out notification #467

merged 2 commits into from Oct 28, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 28, 2019

Display notification popup when user disables promos from a promo modal.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Display notification when user opts out of promos from a promo
Loading status checks…
90d1334
@wlycdgr wlycdgr requested review from christophertino, Eden12345, jsignanini, zarembsky and ghostery/ghostery as code owners Oct 28, 2019
@christophertino christophertino added this to the 8.4.4 milestone Oct 28, 2019
@christophertino christophertino changed the base branch from master to develop Oct 28, 2019
@christophertino
christophertino approved these changes Oct 28, 2019
View changes
@wlycdgr
Merge develop in
Loading status checks…
fa6f790
@christophertino
christophertino approved these changes Oct 28, 2019
View changes
@christophertino christophertino merged commit 307bb21 into develop Oct 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1871/promo-modal-opt-out-notification branch Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

@jsignanini jsignanini

@zarembsky zarembsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino