GH-1774 et al; promo modal logic bug fixes #468
Merged
Conversation
…st panel target to 7 opens on staging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Pop first Insights modal as soon as engagement conditions are met - do not wait 30 days after install (a late addition to GH-1774 that had slipped through the cracks)
Keep popping Initial Plus promo in Panel until user makes a required choice of either Select Basic or Select Plus (an OG requirement, was implemented but changes had introduced a regression breaking this)
Up the engagement (open panel) target for the Insights modal on staging from 3 to 7 to facilitate testing.
Upped the period from 20 to 40 seconds on staging.
Have you followed the guidelines in CONTRIBUTING.md?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you added an explanation of what your changes do?
Does your submission pass tests?
Did you lint your code prior to submission?