Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promo modal css fixes and upgrades #469

Merged
merged 2 commits into from Oct 29, 2019
Merged

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Oct 29, 2019

  • Revert to the original nicer fonts in the Plus promo modals

  • Localization-proof promo modal CSS

  • Specify localization character limits in messages json file.

  • Have you followed the guidelines in CONTRIBUTING.md?

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

  • Have you added an explanation of what your changes do?

  • Does your submission pass tests?

  • Did you lint your code prior to submission?

wlycdgr added 2 commits Oct 29, 2019
…s. finish localization-proofing plus promos
…nsights promo modal css. Specify character limits for promo strings in messages file.
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Oct 29, 2019
@wlycdgr wlycdgr requested a review from christophertino Oct 29, 2019
@christophertino christophertino merged commit b3e228d into develop Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the plus-promo-modals-css-upgrade branch Oct 29, 2019
@christophertino christophertino added this to the 8.4.4 milestone Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants