Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promo modal css fixes and upgrades #469

Merged
merged 2 commits into from Oct 29, 2019
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev
Add header to insights promo modal scss partial. Localization-proof i…
…nsights promo modal css. Specify character limits for promo strings in messages file.
  • Loading branch information
wlycdgr committed Oct 29, 2019
commit 46beb6695713a57bb2457200e33368c64ee4d596
@@ -527,25 +527,31 @@
"message": "Set Up Ghostery"
},
"panel_insights_audit_tags": {
"message": "Audit marketing tags on a page"
"message": "Audit marketing tags on a page",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 30."
},
"panel_insights_promotion_explore_trends": {
"message": "Explore global digital trends"
"message": "Explore global digital trends",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 29."
},
"panel_insights_promotion_call_to_action": {
"message": "Try for free"
},
"panel_insights_promotion_header": {
"message": "Try Ghostery Insights"
"message": "Try Ghostery Insights",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 35."
},
"panel_insights_promotion_description": {
"message": "Speed up and clean up digital user experience with our professional tag analytics tool."
"message": "Speed up and clean up digital user experience with our professional tag analytics tool.",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 90."
},
"panel_insights_promotion_trace_poor_performance": {
"message": "Trace sources of poor performance"
"message": "Trace sources of poor performance",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 33."
},
"panel_insights_promotion_watch_pings": {
"message": "Watch pings fire in real-time"
"message": "Watch pings fire in real-time",
"description": "Appears in a non-responsive modal. Character limit (including spaces and punctuation): 29."
},
"panel_about_panel_header": {
"message": "About Ghostery Browser Extension"
@@ -1,3 +1,20 @@
/**
* Insights Promo Modal Sass
*
* Ghostery Browser Extension
* https://www.ghostery.com/
*
* Copyright 2019 Ghostery, Inc. All rights reserved.
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0
*/

// Insights Promo Modal
$standard-font-family: Roboto, "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;
$condensed-font-family: Roboto Condensed, "Open Sans", "Helvetica Neue", Helvetica, Arial, sans-serif;

.InsightsModal__content {
background-color: $alabaster;
position: relative;
@@ -17,7 +34,7 @@
}

.InsightsModal__header {
font-family: 'Roboto';
font-family: $standard-font-family;
height: 27.1px;
font-size: 20px;
font-weight: 900;
@@ -33,7 +50,7 @@
font-weight: 500;
text-align: center;
margin-bottom: 12.8px;
font-family: 'Roboto';
font-family: $standard-font-family;
}

.InsightsModal__features {
@@ -47,7 +64,7 @@
}

.InsightsModal__feature-text {
font-family: 'Roboto';
font-family: $standard-font-family;
font-size: 14px;
line-height: 39px;
color: $medium-gray;
@@ -70,14 +87,14 @@
.InsightsModal__call-to-action {
display: flex;
justify-content: center;
width: 176px;
padding: 0px 50px 0px; // more localization-proof than hardcoding width
height: 36px;
margin-top: 18px;
border-radius: 2px;
box-shadow: 0 2px 2px 0 rgba(0, 0, 0, 0.24), 0 0 2px 0 rgba(0, 0, 0, 0.12);
background-image: linear-gradient(101deg, #070e18, #1678a0);
font-size: 14px;
font-family: 'Roboto Condensed';
font-family: $condensed-font-family;
letter-spacing: .5px;
color: $white;
line-height: 36px;
@@ -88,7 +105,7 @@
}

.InsightsModal__link {
font-family: 'Roboto';
font-family: $standard-font-family;
font-size: 15px;
color: $tundora;
&:hover {
ProTip! Use n and p to navigate between commits in a pull request.