Fixes for metrics bugs GH-1001 and GH-1022 #47
Merged
Conversation
Contributor
zarembsky
commented
Apr 26, 2018
•
|
added 2 commits
Apr 26, 2018
zarembsky
changed the title
app/panel/reducers/panel.js
Outdated
| @@ -110,10 +109,10 @@ export default (state = initialState, action) => { | |||
| default: | |||
| break; | |||
| } | |||
| sendMessage('setPanelData', { [action.data.featureName]: !action.data.isEnabled }); | |||
jsignanini
Apr 30, 2018
Member
@zarembsky please add the sendMessage('ping', ...) check and call as a promise returned from the previous sendMessage call to make sure it happens after the panel data has been set.
@zarembsky please add the sendMessage('ping', ...) check and call as a promise returned from the previous sendMessage call to make sure it happens after the panel data has been set.
…set in the background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.