Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dollar sign displays correctly across browsers in promo modals #471

Merged
merged 1 commit into from Nov 12, 2019
Merged

Ensure dollar sign displays correctly across browsers in promo modals #471

merged 1 commit into from Nov 12, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Nov 12, 2019

Fix double dollar sign Edge issue

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Ensure dollar sign displays correctly across browsers in promo modals
Loading status checks…
5fac7e7
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Nov 12, 2019
@wlycdgr wlycdgr requested a review from christophertino Nov 12, 2019
@christophertino
christophertino approved these changes Nov 12, 2019
View changes
@christophertino christophertino merged commit 7495514 into develop Nov 12, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@christophertino christophertino deleted the bugfix/GH-1876 branch Nov 12, 2019
@christophertino christophertino added this to the 8.4.4 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.4
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino