Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dollar sign displays correctly across browsers in promo modals #471

Merged
merged 1 commit into from Nov 12, 2019
+33 −47
Merged

Ensure dollar sign displays correctly across browsers in promo modals #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Loading status checks…
Ensure dollar sign displays correctly across browsers in promo modals
  • Loading branch information
@wlycdgr
wlycdgr committed Nov 12, 2019
commit 5fac7e7f4fd11899c26c38bb382cb6ec7ca4eeba
5 _locales/de/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/en/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/es/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/fr/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/hu/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/it/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
11 _locales/ja/messages.json
View file
Open in desktop
@@ -1497,10 +1497,10 @@
"hub_tutorial_antisuite_antitracking_description": {
"message": "サイトが個人を特定できるようなデータポイントを削除します。"
},
"hub_products_page_title" : {
"hub_products_page_title": {
"message": "Ghostery ハブ - その他のGhostery製品を試す"
},
"hub_products_header_title" : {
"hub_products_header_title": {
"message": "Ghosteryの機能でよりスマートにブラウジング！"
},
"hub_products_header_description": {
@@ -1846,7 +1846,7 @@
"subscription_themes_tooltip": {
"message": "Ghosteryのカラースキームは変更できます！"
},
"subscription_charge_date" : {
"subscription_charge_date": {
"message": "次回のお支払日"
},
"subscription_expired": {
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery プラス"
},
"locale_appropriate_currency_icon": {
"message": "$$ ",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/ko/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/nl/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "€",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/pl/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/pt_BR/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/ru/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/zh_CN/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
5 _locales/zh_TW/messages.json
View file
Open in desktop
@@ -2017,9 +2017,8 @@
"ghostery_plus": {
"message": "Ghostery Plus"
},
"locale_appropriate_currency_icon": {
"message": "$$",
"description": "Use '$$' to mean '$'. '$' has a special meaning in the code and the first '$' tells the browser to ignore the special meaning of the second '$' and print it literally."
"dollar_sign": {
"message": "$"
},
"plus_monthly_subscription_price_number": {
"message": "2"
4 app/shared-components/PlusPromoModal/PlusPromoModal.jsx
View file
Open in desktop
@@ -90,7 +90,7 @@ const PlusPromoModal = (props) => {
<div className={`${optionDescriptionBoxClassNames} basic`}>
<div className="PlusPromoModal__option-header basic">{t('ghostery_basic')}</div>
<div className="PlusPromoModal__price-text basic">
<span className="PlusPromoModal__currency-sign">{t('locale_appropriate_currency_icon')}</span>
<span className="PlusPromoModal__currency-sign" dangerouslySetInnerHTML={{ __html: t('dollar_sign') }} />
<span className="PlusPromoModal__amount">0</span>
<span> </span>
<span className="PlusPromoModal__per-month">{t('per_month')}</span>
@@ -111,7 +111,7 @@ const PlusPromoModal = (props) => {
</div>
<div className="PlusPromoModal__option-header plus">{t('ghostery_plus')}</div>
<div className="PlusPromoModal__price-text plus">
<span className="PlusPromoModal__currency-sign">{t('locale_appropriate_currency_icon')}</span>
<span className="PlusPromoModal__currency-sign" dangerouslySetInnerHTML={{ __html: t('dollar_sign') }} />
<span className="PlusPromoModal__amount">{t('plus_monthly_subscription_price_number')}</span>
<span> </span>
<span className="PlusPromoModal__per-month">{t('per_month')}</span>
ProTip! Use n and p to navigate between commits in a pull request.