Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name fields of hub plus promo modal pings #473

Closed
wants to merge 1 commit into from
Closed

Fix name fields of hub plus promo modal pings #473

wants to merge 1 commit into from

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Nov 14, 2019

While trying to pull plus promo metrics data for Jeremy, I discovered that the Hub plus promo pings were broken. This should get them working.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix name fields of hub plus promo modal pings
Loading status checks…
95340ec
@wlycdgr wlycdgr requested review from Eden12345 and ghostery/ghostery as code owners Nov 14, 2019
@wlycdgr wlycdgr requested a review from christophertino Nov 14, 2019
@wlycdgr wlycdgr closed this Nov 15, 2019
@christophertino christophertino deleted the hotfix/fix-hub-plus-promo-pings branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eden12345 Eden12345

@ghostery/ghostery Ghostery

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@wlycdgr