Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/remove initial plus promo pings #474

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Nov 15, 2019

Removes the hub and panel initial plus promo pings (that would never be sent because the new user has not yet had a chance to opt in to non-essential data collection).

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr wlycdgr requested review from Eden12345 and ghostery/ghostery as code owners Nov 15, 2019
@wlycdgr wlycdgr requested a review from christophertino Nov 15, 2019
@christophertino christophertino added this to the 8.4.5 milestone Nov 15, 2019
Copy link
Member

@christophertino christophertino left a comment

@wlycdgr Please also remove these from the Metrics class

@wlycdgr wlycdgr requested a review from jsignanini as a code owner Nov 15, 2019
@wlycdgr
Copy link
Member Author

@wlycdgr wlycdgr commented Nov 15, 2019

@wlycdgr Please also remove these from the Metrics class

@christophertino Forgot about Metrics, my bad. Done.

@christophertino christophertino merged commit cba008f into develop Nov 15, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the hotfix/remove-initial-plus-promo-pings branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants