Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/remove initial plus promo pings #474

Merged
merged 4 commits into from Nov 15, 2019
Merged
Changes from 1 commit
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Remove hub initial plus promo modal pings

  • Loading branch information
wlycdgr committed Nov 15, 2019
commit 23768258988d95474d32ea2bbc26f0013d811153
@@ -70,8 +70,6 @@ class HomeViewContainer extends Component {
this.props.actions.markPlusPromoModalShown();

sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {});

sendMessage('SEND_PING', 'promo_modals_select_basic_hub');
}

/**
@@ -85,8 +83,6 @@ class HomeViewContainer extends Component {

sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {});

sendMessage('SEND_PING', 'promo_modals_select_plus_hub');

window.open(`https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=intro_hub`, '_blank');
}

@@ -111,9 +107,6 @@ class HomeViewContainer extends Component {
};

const showPromoModal = !isPlus && !plus_promo_modal_shown;
if (showPromoModal) {
sendMessage('SEND_PING', 'promo_modals_show_plus_choice_hub');
}

return (
<div className="full-height">
ProTip! Use n and p to navigate between commits in a pull request.