Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/remove initial plus promo pings #474

Merged
merged 4 commits into from Nov 15, 2019
Merged
Changes from all commits
Commits
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

@@ -70,8 +70,6 @@ class HomeViewContainer extends Component {
this.props.actions.markPlusPromoModalShown();

sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {});

sendMessage('ping', 'promo_modals_select_basic_hub');
}

/**
@@ -85,8 +83,6 @@ class HomeViewContainer extends Component {

sendMessage('SET_PLUS_PROMO_MODAL_SEEN', {});

sendMessage('ping', 'promo_modals_select_plus_hub');

window.open(`https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=intro_hub`, '_blank');
}

@@ -111,9 +107,6 @@ class HomeViewContainer extends Component {
};

const showPromoModal = !isPlus && !plus_promo_modal_shown;
if (showPromoModal) {
sendMessage('ping', 'promo_modals_show_plus_choice_hub');
}

return (
<div className="full-height">
@@ -235,8 +235,6 @@ class Panel extends React.Component {
// we do not mark the choice-required initial plus promo as 'seen' until
// the user has clicked Select Basic or Select Plus
sendMessage('promoModals.sawPlusPromo', {});

sendMessage('ping', 'promo_modals_select_basic_panel');
};

/**
@@ -250,8 +248,6 @@ class Panel extends React.Component {
// the user has clicked Select Basic or Select Plus
sendMessage('promoModals.sawPlusPromo', {});

sendMessage('ping', 'promo_modals_select_plus_panel');

const url = `https://checkout.${DOMAIN}.com/plus?utm_source=gbe&utm_campaign=in_app`;
sendMessage('openNewTab', {
url,
@@ -324,7 +320,6 @@ class Panel extends React.Component {
}

// promoModal === 'plus_initial'
sendMessage('ping', 'promo_modals_show_plus_choice_panel');
return (
<PlusPromoModal
show
@@ -1,5 +1,7 @@
{
"manifest_version": 2,
"debug": true,
"log": true,
"applications": {
"gecko": {
"id": "firefox@ghostery.com",
@@ -100,4 +102,4 @@
"app/images/*",
"dist/css/rewards_styles.css"
]
}
}
@@ -285,14 +285,8 @@ class Metrics {
// Promo Modals - Ghostery 8.4.4+
case 'promo_modals_insights_upgrade_cta':
case 'promo_modals_plus_upgrade_cta':
case 'promo_modals_select_plus_panel':
case 'promo_modals_select_basic_panel':
case 'promo_modals_select_plus_hub':
case 'promo_modals_select_basic_hub':
case 'promo_modals_decline_insights_upgrade':
case 'promo_modals_decline_plus_upgrade':
case 'promo_modals_show_plus_choice_hub':
case 'promo_modals_show_plus_choice_panel':
case 'promo_modals_show_upgrade_plus':
case 'promo_modals_show_insights':
this._sendReq(type, ['all']);
ProTip! Use n and p to navigate between commits in a pull request.