Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1885/Fix typo in Account#getUserSubscriptionData #480

Merged
merged 2 commits into from Dec 16, 2019
Merged

GH-1885/Fix typo in Account#getUserSubscriptionData #480

merged 2 commits into from Dec 16, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Nov 25, 2019

Ensure that customer.subscription in Account#getUserSubscriptionData is actually cast to an array if it isn't one already.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix typo in Account#getUserSubscriptionData
Loading status checks…
1ed9764
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Nov 25, 2019
@wlycdgr wlycdgr requested a review from jsignanini Nov 25, 2019
@christophertino christophertino added this to the 8.4.6 milestone Dec 16, 2019
@christophertino
Merge branch 'develop' into hotfix/GH-1885
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5974d46
@christophertino
christophertino approved these changes Dec 16, 2019
View changes
@christophertino christophertino merged commit 856ccc2 into develop Dec 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the hotfix/GH-1885 branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino