Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1895 and GH-1896: Midnight promos #484

Closed
wants to merge 10 commits into from
Closed

GH-1895 and GH-1896: Midnight promos #484

wants to merge 10 commits into from

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Dec 12, 2019

Implements the hub and panel Premium promo modals, which replace the initial and upgrade Plus promo modals.

Does not include the GH-1899 telemetry ticket. That will be a separate PR.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
aleksandr-cliqz and others added 10 commits Nov 22, 2019
* M20-52: first proto for myoffrz rewards

* M20-52: linter

* M20-52: typos in package.json and yarn.lock

* M20-52: typos part 2 in yarn and package.json

* M20-52: adding test locales for en

* M20-52: turnoff rewards from reward-box

* M20-52: adding web_accessible_resources for offers-reminder

* M20-52: myoffrz actions was renamed

* M20-52: turnoff ghostery rewards (just adding flag)

* M20-52: move inline styles to css file

* M20-52: fix typos

* M20-52: [locales] remove duplicates

* M20-52: rename locales

* M20-52: locales adding support for goo chrome

* M20-52: known rewards keys for poland

* M20-52: rearrange locale keys

* M20-52: fix typos

* M20-52: clean code: src and content-scripts

* M20-52: fix typos

* M20-52: clean up for app/panel/rewards

* M20-52: clean up for css and images

* M20-52: fix for eslint

* M20-52: fix tests

* M20-52: fixing TODOs

* M20-52: clean up for unread offers

* M20-52: fix typos

* M20-52: adding missing signals

* M20-52: adding border to iframe

* M20-52: reset rewards_opted_in after migration

* M20-52: revert pl translations

* M20-52: fix duplicate translations

* M20-52: remove unused eact-shadow-dom-retarget-events

* M20-52: remove unused code

* M20-52: fix typos yarn,lock

* M20-52: listen to myOffrzTurnoff in different place

* M20-52: adding events for myoffrz:turnoff

* test

* fix test

* M20-52: new cliqz version 7.40.2

* M20-52: update yarn.lock
…he new Premium promo
@wlycdgr wlycdgr requested review from christophertino, Eden12345, jsignanini, zarembsky and ghostery/ghostery as code owners Dec 12, 2019
@wlycdgr wlycdgr closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants