GH-1895 and GH-1896: Midnight promos #485
Merged
+510
−696
Conversation
…he new Premium promo
wlycdgr
requested review from
Eden12345,
zarembsky and
ghostery/ghostery
as
code owners
|
See 2 notes. Also I've noticed that the hub keeps showing the Midnight promo even after I've purchased premium and signed in, is that intended? |
|
Premium subscribers should no longer see promo in either hub or panel, if my smoke tests aren't lying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Implements the hub and panel Premium promo modals, which replace the initial and upgrade Plus promo modals.
Does not include the GH-1899 telemetry ticket, which will get its own PR.