Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1895, GH-1896, and GH-1899: Premium promo ux update and telemetry #486

Merged
merged 3 commits into from Dec 16, 2019
Merged

GH-1895, GH-1896, and GH-1899: Premium promo ux update and telemetry #486

merged 3 commits into from Dec 16, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Dec 12, 2019

Do not show the link to subscribe to Plus in the Premium modals if the user is already a Plus subscriber.

Add utm params to Download clicks in the Premium modals so we know whether the user came from the panel or the hub.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
wlycdgr added 2 commits Dec 12, 2019
@wlycdgr
Set debug and log for testing promos. Do not show Plus subscribe link…
Loading status checks…
fabae81 
… in promo if user is a Plus subscriber.
@wlycdgr
Add utm params to Premium promo modal Download clicks
Loading status checks…
05e75c4
@wlycdgr wlycdgr requested review from Eden12345 and ghostery/ghostery as code owners Dec 12, 2019
@wlycdgr wlycdgr requested review from jsignanini and christophertino Dec 12, 2019
@christophertino christophertino added this to the 8.4.6 milestone Dec 16, 2019
@christophertino
christophertino approved these changes Dec 16, 2019
View changes
@christophertino
Merge branch 'develop' into premium-promo-UX-update-and-telemetry
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6761558
@christophertino christophertino merged commit 1622cc7 into develop Dec 16, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the premium-promo-UX-update-and-telemetry branch Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

@jsignanini jsignanini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino