Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1895 and GH-1896: Insights promo modal logic bugfix #488

Merged
merged 2 commits into from Dec 17, 2019
Merged

GH-1895 and GH-1896: Insights promo modal logic bugfix #488

merged 2 commits into from Dec 17, 2019

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Dec 16, 2019

Insights modal broke because I refactored PromoModals#_hasEngagedFrequently to use reduce and postfix incremented the accumulator instead of prefix incrementing it.

Let this be a lesson to me not to fix what is not broken in the middle of a crunch.

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
@wlycdgr
Fix bug in PromoModals#_hasEngagedFrequently
Loading status checks…
5eaa94d
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Dec 16, 2019
@christophertino
Merge branch 'develop' into insights-promo-modal-logic-bugfix
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3e6ae37
@christophertino
christophertino approved these changes Dec 17, 2019
View changes
@christophertino christophertino added this to the 8.4.6 milestone Dec 17, 2019
@christophertino christophertino merged commit 071fe0b into develop Dec 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the insights-promo-modal-logic-bugfix branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@wlycdgr @christophertino