Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1895 and GH-1896: Insights promo modal logic bugfix #488

Merged
merged 2 commits into from Dec 17, 2019
+1 −1
Merged

GH-1895 and GH-1896: Insights promo modal logic bugfix #488

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eaa94d
Fix bug in PromoModals#_hasEngagedFrequently
wlycdgr Dec 16, 2019
3e6ae37
Merge branch 'develop' into insights-promo-modal-logic-bugfix
christophertino Dec 17, 2019
File filter
Filter file types
Jump to
Jump to file
Failed to load files.

Always

Just for now

Next
Loading status checks…
Fix bug in PromoModals#_hasEngagedFrequently
  • Loading branch information
@wlycdgr
wlycdgr committed Dec 16, 2019
commit 5eaa94dcf3fd931d42cb896489100302b2da417c
2 src/classes/PromoModals.js
View file
Open in desktop
@@ -96,7 +96,7 @@ class PromoModals {
static _hasEngagedFrequently() {
const { engaged_daily_count } = conf.metrics || [];

const very_engaged_days = engaged_daily_count.reduce((acc, count) => (count >= DAILY_INSIGHTS_TARGET ? acc++ : acc), 0);
const very_engaged_days = engaged_daily_count.reduce((acc, count) => (count >= DAILY_INSIGHTS_TARGET ? ++acc : acc), 0);

return very_engaged_days >= WEEKLY_INSIGHTS_TARGET;
}
ProTip! Use n and p to navigate between commits in a pull request.