Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1693: Premium promo modal translation string ui fixes #489

Merged
merged 4 commits into from Dec 18, 2019
+43 −44
Merged

GH-1693: Premium promo modal translation string ui fixes #489

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70662bc
CSS changes to better accommodate different locale strings
wlycdgr Dec 17, 2019
40f4ae9
Additional CSS fixes to make sure the Premium modal looks nice in as …
wlycdgr Dec 17, 2019
1a5a369
CSS cleanup for Premium promo modal
wlycdgr Dec 17, 2019
5920459
Rearrange strings in Premium promo modal based on feedback from product
wlycdgr Dec 18, 2019
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev
Loading status checks…
Rearrange strings in Premium promo modal based on feedback from product
  • Loading branch information
@wlycdgr
wlycdgr committed Dec 18, 2019
commit 592045989abd8af08aaa25ec8e78fbe9fc86e5a6
8 app/shared-components/PremiumPromoModal/PremiumPromoModal.jsx
View file
Open in desktop
@@ -58,7 +58,7 @@ const PremiumPromoModal = (props) => {
<div className="PremiumPromoModal__header-beta-icon" />
</div>
</div>
<div className="PremiumPromoModal__sub-header" dangerouslySetInnerHTML={{ __html: `${t('full_coverage_protection_promise')}. ${t('seven_day_free_trial')}` }} />
<div className="PremiumPromoModal__sub-header">{t('full_coverage_protection_promise')}</div>
<div className="PremiumPromoModal__features-container">
<div className="PremiumPromoModal__feature-column">
<div className="PremiumPromoModal__feature">
@@ -78,14 +78,12 @@ const PremiumPromoModal = (props) => {
<div className="PremiumPromoModal__feature">
<span className="PremiumPromoModal__checked-circle-icon" />
<div className="PremiumPromoModal__feature-text">
{t('custom_whitelist_options')}
{t('historical_tracking_insights')}
</div>
</div>
<div className="PremiumPromoModal__feature">
<span className="PremiumPromoModal__checked-circle-icon" />
<div className="PremiumPromoModal__feature-text">
{t('historical_tracking_insights')}
</div>
<div className="PremiumPromoModal__feature-text" dangerouslySetInnerHTML={{ __html: t('seven_day_free_trial') }} />
</div>
</div>
</div>
ProTip! Use n and p to navigate between commits in a pull request.