Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'trust site' on localhost #491

Merged
merged 5 commits into from Feb 3, 2020
Merged

Fix 'trust site' on localhost #491

merged 5 commits into from Feb 3, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Jan 28, 2020

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?
  • When localhost is trusted, it is added to the whitelist with it's corresponding port number
  • Issue #470
@benstrumeyer benstrumeyer requested a review from ghostery/ghostery as a code owner Jan 28, 2020
@christophertino
Copy link
Member

@christophertino christophertino commented Jan 28, 2020

@benstrumeyer you'll need to bump the node version in the Travis config

- "lts/carbon"

Set to lts/dubnium

@christophertino christophertino added this to the 8.4.7 milestone Jan 29, 2020
Copy link
Member

@christophertino christophertino left a comment

@benstrumeyer let's use a url-parser to make this easier.

import { URL } from '@cliqz/url-parser';

Inside your if statement:
const url = new URL(pageUrl);
Then look for the host property of that url object.

@christophertino christophertino changed the title Trust localhost Fix 'trust site' on localhost Jan 31, 2020
@christophertino christophertino merged commit 4afff29 into develop Feb 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the trust-localhost branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants