Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Purplebox on Firefox Android #494

Merged
merged 8 commits into from Feb 14, 2020
Merged

Disable Purplebox on Firefox Android #494

merged 8 commits into from Feb 14, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 5, 2020

  • [*] Have you followed the guidelines in CONTRIBUTING.md?
  • [*] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [*] Have you added an explanation of what your changes do?
  • [*] Does your submission pass tests?
  • [*] Did you lint your code prior to submission?

Remove purple box on android FF

@benstrumeyer benstrumeyer requested a review from zarembsky as a code owner Feb 5, 2020
@benstrumeyer benstrumeyer reopened this Feb 6, 2020
@benstrumeyer benstrumeyer removed the request for review from zarembsky Feb 6, 2020
Copy link
Member

@christophertino christophertino left a comment

This will work for new installs, but existing users would not be affected since the Conf property has already been set. We need to add a check in the init flow to turn off this setting for FFA users.

Check background.js initializeGhosteryModules. Above function scheduledTasks() , throw in a quick check for FFA and then add conf.show_alert = false.

@christophertino christophertino added this to the 8.4.7 milestone Feb 13, 2020
@benstrumeyer benstrumeyer requested a review from christophertino Feb 13, 2020
christophertino and others added 3 commits Feb 14, 2020
…nsion into remove-purple-box
@christophertino christophertino changed the title Remove purple box on android Disable Purplebox on Firefox Android Feb 14, 2020
@christophertino christophertino merged commit 22c66d6 into develop Feb 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the remove-purple-box branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants