Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1936 & GH-1920 Remove email opt-in from account creation in panel and hub #495

Merged
merged 8 commits into from Feb 14, 2020

Conversation

@benstrumeyer
Copy link
Contributor

@benstrumeyer benstrumeyer commented Feb 6, 2020

  • [*] Have you followed the guidelines in CONTRIBUTING.md?
  • [*] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • [*] Have you added an explanation of what your changes do?
  • [*] Does your submission pass tests?
  • [*] Did you lint your code prior to submission?
  • Automatically sign up for emails when registering an account in the panel or hub
  • Remove checkboxes to opt-in on account creation pages

Tickets:

benstrumeyer added 2 commits Feb 6, 2020
@benstrumeyer benstrumeyer requested review from Eden12345, zarembsky and ghostery/ghostery as code owners Feb 6, 2020
@benstrumeyer benstrumeyer requested a review from Eden12345 Feb 11, 2020
Copy link
Contributor

@Eden12345 Eden12345 left a comment

If I understand correctly, we can remove this opt in functionality from the Ghostery Extension altogether as changes are being implemented in the Account project that will automatically opt users in on account creation.

@benstrumeyer benstrumeyer requested a review from Eden12345 Feb 11, 2020
Copy link
Contributor

@Eden12345 Eden12345 left a comment

Looks good to me, as long as this is merged/released after the changes to the Account project (that automatically opts users in on account creation) are deployed to production.

@christophertino christophertino added this to the 8.4.7 milestone Feb 13, 2020
Copy link
Member

@christophertino christophertino left a comment

@benstrumeyer looks like handlePromotionsCheckboxChange and promotionsChecked are still in the unit tests. Also legacy sass for #create-account-promotions {

@benstrumeyer benstrumeyer requested a review from christophertino Feb 13, 2020
@christophertino christophertino changed the title GH-1936 & GH-1920 Opt-in to emails on account creation GH-1936 & GH-1920 Remove email opt-in from account creation in panel and hub Feb 14, 2020
Copy link
Member

@christophertino christophertino left a comment

Looks good

@christophertino christophertino merged commit cb14abf into develop Feb 14, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the opt-into-emails branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants