Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1936 & GH-1920 Remove email opt-in from account creation in panel and hub #495

Merged
merged 8 commits into from Feb 14, 2020
+7 −158
Merged

GH-1936 & GH-1920 Remove email opt-in from account creation in panel and hub #495

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb7fd8b
Opt-in to emails by default on account creation in panel and hub. Rem…
benstrumeyer Feb 6, 2020
dccb01e
Update snapshots
benstrumeyer Feb 6, 2020
9ec8881
Add function to proptypes
benstrumeyer Feb 11, 2020
28d6793
Remove opt into emails entirely
benstrumeyer Feb 11, 2020
088ca8c
Update styling after removing checkbox; approved by design team
Eden12345 Feb 11, 2020
5eacdb8
Merge branch 'develop' into opt-into-emails
christophertino Feb 13, 2020
c220224
Remove promotion unit tests and scss
benstrumeyer Feb 13, 2020
d619a8b
Merge branch 'opt-into-emails' of github.com:ghostery/ghostery-extens…
benstrumeyer Feb 13, 2020
File filter
Filter file types
Clear filters
Jump to
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

Update snapshots

  • Loading branch information
@benstrumeyer
benstrumeyer committed Feb 6, 2020
commit dccb01efbf61dfac83c9d4a4d2a56805acf03f7a
44 app/hub/Views/CreateAccountView/__tests__/__snapshots__/CreateAccountView.test.jsx.snap
View file
Open in desktop
@@ -169,28 +169,6 @@ exports[`app/hub/Views/CreateAccount component Snapshot tests with react-test-re
onClick={[Function]}
/>
</div>
<div
className="CreateAccountView__checkboxContainer CreateAccountView--marginBottom flex-container"
>
<div
className="ToggleCheckbox ToggleCheckbox--flush-left"
onClick={[Function]}
>
<svg
viewBox="0 0 24 24"
>
<path
d="M19 5v14H5V5h14m0-2H5c-1.1 0-2 .9-2 2v14c0 1.1.9 2 2 2h14c1.1 0 2-.9 2-2V5c0-1.1-.9-2-2-2z"
/>
</svg>
</div>
<span
className="CreateAccountView__inputLabel clickable"
onClick={[Function]}
>
hub_create_account_checkbox_promotions
</span>
</div>
</div>
</div>
<div
@@ -437,28 +415,6 @@ exports[`app/hub/Views/CreateAccount component Snapshot tests with react-test-re
onClick={[Function]}
/>
</div>
<div
className="CreateAccountView__checkboxContainer CreateAccountView--marginBottom flex-container"
>
<div
className="ToggleCheckbox ToggleCheckbox--flush-left ToggleCheckbox--active"
onClick={[Function]}
>
<svg
viewBox="0 0 24 24"
>
<path
d="M19 3H5c-1.11 0-2 .9-2 2v14c0 1.1.89 2 2 2h14c1.11 0 2-.9 2-2V5c0-1.1-.89-2-2-2zm-9 14l-5-5 1.41-1.41L10 14.17l7.59-7.59L19 8l-9 9z"
/>
</svg>
</div>
<span
className="CreateAccountView__inputLabel clickable"
onClick={[Function]}
>
hub_create_account_checkbox_promotions
</span>
</div>
</div>
</div>
<div
ProTip! Use n and p to navigate between commits in a pull request.