Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1477 Wildcard/Regex Whitelisting #497
GH-1477 Wildcard/Regex Whitelisting #497
Changes from 1 commit
7db8cdd7fdc2d8f07e1513cff5eba03896fb025685393048748e8e6063ec3b6fc1f621fcd5e9ab9186bca726e87be06d00863f225032cbc68a6533c5e6e3c216b89a71c63fcbd35ef226fdf07bab3ce25abe1de5File filter
Jump to
Eden12345Feb 11, 2020
Contributor
I'm not sure if I'm missing something here with the node module you're using, but when do we actually use this value that the var
regexis initialized with?Eden12345Feb 11, 2020
Contributor
Did you mean to pass the var
regexto the firstRegExpinstantiation and thewildcardPatternvar initialization? And if so, do you still need the try/catches?benstrumeyerFeb 11, 2020
Author
Contributor
Yup, that's absolutely what I meant to do. I was also able to get rid of the try/catches because of the escape function you commented below. Thanks for the help.