Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1477 Wildcard/Regex Whitelisting #497
GH-1477 Wildcard/Regex Whitelisting #497
Changes from 1 commit
7db8cdd7fdc2d8f07e1513cff5eba03896fb025685393048748e8e6063ec3b6fc1f621fcd5e9ab9186bca726e87be06d00863f225032cbc68a6533c5e6e3c216b89a71c63fcbd35ef226fdf07bab3ce25abe1de5File filter
Jump to
Eden12345Feb 10, 2020
Contributor
Just curious as to why we aren't implementing the paygating in this PR?
benstrumeyerFeb 11, 2020
Author
Contributor
Chris said don't worry about it for now. I think he wanted me to focus on implementation first.
Eden12345Feb 11, 2020
Contributor
Ah okay, then let's update the ticket to reflect that — unless @christophertino you would like me to pair up with @benstrumeyer and knock out the paygating real quick? It should be pretty straightforward since we have the account/subscription info in the
AccountReducer.Eden12345Feb 11, 2020
Contributor
@benstrumeyer Looks like @christophertino doesn't want this to be a Plus feature anyway, and he said he'd update the ticket to refelect that.
Eden12345Feb 11, 2020
Contributor
Let's remove this variable if we aren't going to be using it.
christophertinoFeb 14, 2020
Member
We still need front-end validation here so that we can prevent users from adding urls in unsupported formats. You should check that the url entered is either a valid url or a valid regex, and show an error if not.
benstrumeyerFeb 18, 2020
Author
Contributor
I checked if it's a valid URL, wildcard, or regex and updated the error messages. Let me know if you'd like to change anything else