Skip to content

/ ghostery-extension

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-1791 / add locale-appropriate formatting to historical stats numbers #498

Merged
merged 2 commits into from Feb 13, 2020
Merged

GH-1791 / add locale-appropriate formatting to historical stats numbers #498

merged 2 commits into from Feb 13, 2020

Conversation

@wlycdgr
Copy link
Member

@wlycdgr wlycdgr commented Feb 11, 2020 •
edited

  • Have you followed the guidelines in CONTRIBUTING.md?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do?
  • Does your submission pass tests?
  • Did you lint your code prior to submission?

A small improvement to display historical stats numbers with locale-appropriate formatting (e.g. "3625" becomes "3,625" in US locale)
wlycdgr added 2 commits Feb 11, 2020
@wlycdgr
Add locale-appropriate formatting to historical stat numbers
Loading status checks…
0c53ca7
@wlycdgr
small lintfix in Settings/OptIn component
Loading status checks…
581ac85
@wlycdgr wlycdgr requested a review from ghostery/ghostery as a code owner Feb 11, 2020
@wlycdgr wlycdgr requested review from christophertino and Eden12345 Feb 11, 2020
@Eden12345
Eden12345 approved these changes Feb 11, 2020
View changes
@christophertino
christophertino approved these changes Feb 13, 2020
View changes
@christophertino christophertino added this to the 8.4.7 milestone Feb 13, 2020
@christophertino christophertino merged commit 371fae8 into develop Feb 13, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@christophertino christophertino deleted the GH-1791/commatize-historical-stats branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophertino christophertino

@Eden12345 Eden12345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.4.7
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@wlycdgr @christophertino @Eden12345